fix: accept sysctl/sysfs paths with dots

[nberlee]

fixes: #7878

Pull Request

What? (description)

Why? (reasoning)

Acceptance

Please use the following checklist:

• you linked an issue (if applicable)
• you included tests (if applicable)
• you ran conformance (make conformance)
• you formatted your code (make fmt)
• you linted your code (make lint)
• you generated documentation (make docs)
• you ran unit-tests (make unit-tests)

See make help for a description of the available targets.

[smira]

thanks, for fixing it, it looks like the standard approach is to use first / to make it treat dots as literal dots:

opencontainers/runc#3256

I can fix it up

[smira]

fixed it up to comply with sysctl utility handling, but same idea

[smira]

/ok-to-test

[nberlee]

fixed it up to comply with sysctl utility handling, but same idea

Yes, thank you! This is safer because it mitigates path-traversal. Something only thought of later.

[smira]

Yes, thank you! This is safer because it mitigates path-traversal. Something only thought of later.

actually path traversal was (and still is) a problem... not a security issue per se, as it's part of the machine config, but nice to avoid

[smira]

Yes, thank you! This is safer because it mitigates path-traversal. Something only thought of later.

actually path traversal was (and still is) a problem... not a security issue per se, as it's part of the machine config, but nice to avoid

I added path.Clean() to prevent "stupid" path traversal at least.

[smira]

/m