feat: add extended hardware information to Server and ServerClass CRDs #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
reviewed
Apr 15, 2022
app/sidero-controller-manager/config/samples/metal_v1alpha2_environment.yaml
Outdated
Show resolved
Hide resolved
frezbo
reviewed
Apr 15, 2022
frezbo
reviewed
Apr 15, 2022
This is final part of siderolabs#735, previous part in siderolabs#823. This imports all remaining changes with some fixups minus the webhook changes. This change adds detailed hardware information to the Server CRD. Hardware info is extracted by the agent from SMBIOS. The ServerClass CRD is also updated so more precise qualifiers can be used. Co-authored-by: Gerard de Leeuw <[email protected]> Signed-off-by: Gerard de Leeuw <[email protected]> Signed-off-by: Andrey Smirnov <[email protected]>
Unix4ever
approved these changes
Apr 15, 2022
frezbo
approved these changes
Apr 15, 2022
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is final part of #735, previous part in #823.
This imports all remaining changes with some fixups minus the webhook
changes.
This change adds detailed hardware information to the Server CRD.
Hardware info is extracted by the agent from SMBIOS.
The ServerClass CRD is also updated so more precise qualifiers can be used.
Co-authored-by: Gerard de Leeuw [email protected]
Signed-off-by: Gerard de Leeuw [email protected]
Signed-off-by: Andrey Smirnov [email protected]