feat: add iPXE build with embedded placeholder script #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This builds iPXE with HTTPS enabled, and embedded placeholder script which is to be replaced with the real script during Sidero metal-controller-manager bootstrap. Signed-off-by: Andrey Smirnov <[email protected]>
|
/approve |
Unix4ever
approved these changes
Apr 27, 2021
| finalize: | ||
| - from: /rootfs | ||
| to: / | ||
| # Generating .kpxe via zbin: |
There was a problem hiding this comment.
no, that is doc on how to generate .kpxe..
so the thing is that we want to patch binary in place, but .kpxe is lzma-compressed; so we generate uncompressed version, a tool to generate compressed version, and we patch uncompressed version and compress it on the fly; thsee are the steps to compress the uncompressed version to build final .kpxe
|
/lgtm |
smira
added a commit
to smira/sidero
that referenced
this pull request
Apr 27, 2021
Fixes siderolabs#227 See also siderolabs/pkgs#267 The rough idea is that iPXE binaries we're building contain placeholder script which is replaced on the fly with the actual script which depends on Sidero API endpoint. Patching is a bit tricky for `undionly.kpxe`, as it is compressed, so we patch uncompressed version and compress the final asset after that. Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/sidero
that referenced
this pull request
Apr 27, 2021
Fixes siderolabs#227 See also siderolabs/pkgs#267 The rough idea is that iPXE binaries we're building contain placeholder script which is replaced on the fly with the actual script which depends on Sidero API endpoint. Patching is a bit tricky for `undionly.kpxe`, as it is compressed, so we patch uncompressed version and compress the final asset after that. Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/sidero
that referenced
this pull request
Apr 27, 2021
Fixes siderolabs#227 See also siderolabs/pkgs#267 The rough idea is that iPXE binaries we're building contain placeholder script which is replaced on the fly with the actual script which depends on Sidero API endpoint. Patching is a bit tricky for `undionly.kpxe`, as it is compressed, so we patch uncompressed version and compress the final asset after that. Signed-off-by: Andrey Smirnov <[email protected]>
smira
added a commit
to smira/sidero
that referenced
this pull request
May 4, 2021
Fixes siderolabs#227 See also siderolabs/pkgs#267 The rough idea is that iPXE binaries we're building contain placeholder script which is replaced on the fly with the actual script which depends on Sidero API endpoint. Patching is a bit tricky for `undionly.kpxe`, as it is compressed, so we patch uncompressed version and compress the final asset after that. Signed-off-by: Andrey Smirnov <[email protected]>
talos-bot
pushed a commit
to siderolabs/sidero
that referenced
this pull request
May 5, 2021
Fixes #227 See also siderolabs/pkgs#267 The rough idea is that iPXE binaries we're building contain placeholder script which is replaced on the fly with the actual script which depends on Sidero API endpoint. Patching is a bit tricky for `undionly.kpxe`, as it is compressed, so we patch uncompressed version and compress the final asset after that. Signed-off-by: Andrey Smirnov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds iPXE with HTTPS enabled, and embedded placeholder script
which is to be replaced with the real script during Sidero
metal-controller-manager bootstrap.
Signed-off-by: Andrey Smirnov [email protected]