fix(validation): Validate WAF throtle limit

sid88in · Jun 15, 2022 · 8c286fb · 8c286fb
1 parent 1a5f81b
commit 8c286fb
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 2 deletions.
diff --git a/src/__tests__/validation/__snapshots__/base.test.ts.snap b/src/__tests__/validation/__snapshots__/base.test.ts.snap
@@ -44,6 +44,11 @@ exports[`Valdiation Waf Invalid should validate a Invalid 1`] = `
 /waf/rules/2: must be a valid WAF rule"
 `;
 
+exports[`Valdiation Waf Invalid should validate a Throttle limit 1`] = `
+"/waf/rules/0: must be a valid WAF rule
+/waf/rules/1: must be a valid WAF rule"
+`;
+
 exports[`Valdiation should validate  1`] = `
 ": must have required property 'name'
 : must have required property 'authentication'

diff --git a/src/__tests__/validation/base.test.ts b/src/__tests__/validation/base.test.ts
@@ -187,6 +187,23 @@ describe('Valdiation', () => {
             },
           },
         },
+        {
+          name: 'Throttle limit',
+          config: {
+            ...basicConfig,
+            waf: {
+              rules: [
+                { throttle: 99 },
+                {
+                  throttle: {
+                    name: 'Throttle',
+                    limit: 99,
+                  },
+                },
+              ],
+            },
+          },
+        },
       ];
 
       assertions.forEach((config) => {

diff --git a/src/validation.ts b/src/validation.ts
@@ -187,7 +187,7 @@ export const appSyncSchema = {
           properties: {
             throttle: {
               oneOf: [
-                { type: 'integer' },
+                { type: 'integer', minimum: 100 },
                 {
                   type: 'object',
                   properties: {
@@ -200,7 +200,7 @@ export const appSyncSchema = {
                       type: 'string',
                       enum: ['IP', 'FORWARDED_IP'],
                     },
-                    limit: { type: 'integer' },
+                    limit: { type: 'integer', minimum: 100 },
                     priority: { type: 'integer' },
                     scopeDownStatement: { type: 'object' },
                     forwardedIPConfig: {