qdirstat.desktop file: Exec key value

[mcfadzgit]

Enclosing the field code in double quotes means that if QDirStat is run without parameters, it assumes the current directory is to be opened. Expected behaviour would surely be to prompt for the directory to open, if there is no directory parameter specified?

Also, perhaps it would be helpful to add mount point mime-type to MimeType key value.

Suggested changes:
Exec=qdirstat %u
MimeType=inode/directory;inode/mount-point;

[shundhammer]

Yes, you are right, it should open a directory selection box when started without URL. I was wondering if that plain %u without double quotes might be a security problem, but it turns out that there is no shell expansion involved that might break URLs with, say, blanks into two parameters, so it should still be safe.

In addition to that, the code in main() now also checks if that URL parameter is empty and only uses it if it contains anything.

And while testing this, I discovered that the error handling was not very graceful if an invalid path was specified on the command line; this will now no longer just throw an exception on the command line and make the program appear to have crashed, it now opens an error popup.

Thanks for spotting this!

[shundhammer]

As for that inode/mount-point MimeType, I added it, but I could not see any difference in my desktop environment (KDE 4; will try XFce in the next days) since it does not seem to make a difference between mount points and other directories. Maybe other desktop environments do, so I added your suggested change; if it doesn't help, I don't see that it might hurt anyone.

[mcfadzgit]

Thank you for fixing these issues so swiftly.
It depends on which program is determining MIME-type:
'file' and 'gvfs' return a mount point as 'inode/directory', but 'mimetype' returns 'inode/mount-point'