Follow symlink at command line URL (Fixes #240)

shundhammer · Jan 6, 2024 · e322141 · e322141
1 parent 9889977
commit e322141
Show file tree

Hide file tree

Showing 2 changed files with 63 additions and 4 deletions.
diff --git a/src/MainWindow.cpp b/src/MainWindow.cpp
@@ -8,11 +8,12 @@
 
 
 #include <QApplication>
+#include <QClipboard>
 #include <QCloseEvent>
-#include <QMouseEvent>
-#include <QMessageBox>
 #include <QFileDialog>
-#include <QClipboard>
+#include <QFileInfo>
+#include <QMessageBox>
+#include <QMouseEvent>
 
 #include "MainWindow.h"
 #include "ActionManager.h"
@@ -574,8 +575,10 @@ void MainWindow::openUrl( const QString & url )
 }
 
 
-void MainWindow::openDir( const QString & url )
+void MainWindow::openDir( const QString & origUrl )
 {
+    QString url = handleSymLink( origUrl );
+
     try
     {
         if ( url.startsWith( "/" ) )
@@ -614,6 +617,53 @@ void MainWindow::showOpenDirErrorPopup( const SysCallFailedException & ex )
 }
 
 
+QString MainWindow::handleSymLink( const QString & origUrl ) const
+{
+    QString   url( origUrl );
+    QFileInfo urlInfo( url );
+
+    if ( urlInfo.isSymLink() )
+    {
+        PanelMessage * msg = 0;
+
+        if ( urlInfo.exists() )
+        {
+            QString target = urlInfo.canonicalFilePath();
+
+            logInfo() << "Following symlink \"" << url
+                      <<"\" to target \"" << target << "\"" << endl;
+
+            msg = new PanelMessage( _ui->messagePanel );
+            CHECK_NEW( msg );
+
+            msg->setHeading( tr( "Following symbolic link" ) );
+            msg->setText( tr( "%1 is a symbolic link to %2" )
+                          .arg( url ).arg( target ) );
+            _ui->messagePanel->add( msg );
+
+            url = target;
+        }
+        else
+        {
+            logError() << "Broken symlink";
+
+            msg = new PanelMessage( _ui->messagePanel );
+            CHECK_NEW( msg );
+
+            msg->setHeading( tr( "Broken symbolic link" ) );
+            msg->setText( tr( "%1 is a broken symbolic link to %2" )
+                          .arg( url ).arg( urlInfo.symLinkTarget() ) );
+            msg->setIcon( QPixmap( ":/icons/dialog-warning.png" ) );
+        }
+
+        if ( msg )
+            _ui->messagePanel->add( msg );
+    }
+
+    return url;
+}
+
+
 void MainWindow::askOpenDir()
 {
     QString path;

diff --git a/src/MainWindow.h b/src/MainWindow.h
@@ -497,6 +497,15 @@ protected slots:
      **/
     void showOpenDirErrorPopup( const SysCallFailedException & ex );
 
+    /**
+     * Handle a symlink as an argument to reading a new directory tree
+     * e.g. in openDir(): Follow the symlink and return the target URL.
+     *
+     * If it is a valid symlink, post a PanelMessage to inform the user about
+     * it. If it's a broken symlink, post an error as a PanelMessage.
+     **/
+    QString handleSymLink( const QString & origUrl ) const;
+
     /**
      * Handle mouse buttons: Activate history actions actionGoBack and
      * actionGoForward with the "back" and "forward" mouse buttons as well.