refactor toc, fix toc's styles on rtl, use ref.current instead document.getElementsByClassName
#717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ument.getElementsByClassName`
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
🦋 Changeset detectedLatest commit: 8c376dc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimaMachina
commented
Aug 19, 2022
dimaMachina
commented
Aug 19, 2022
Comment on lines
102
to
112
| <p className="mb-4 font-semibold tracking-tight">On This Page</p> | ||
| <ul> | ||
| <p className="mb-4 font-semibold tracking-tight">On This Page</p> |
There was a problem hiding this comment.
p should not be direct child of ul
dimaMachina
commented
Aug 19, 2022
| setActiveAnchor = useSetActiveAnchor() | ||
| setActiveAnchor ??= useSetActiveAnchor() |
There was a problem hiding this comment.
set only 1 time
dimaMachina
commented
Aug 19, 2022
Comment on lines
-45
to
-52
| @media (prefers-contrast: more) { | ||
| .nextra-nav-container-blur { | ||
| box-shadow: 0 0 0 1px black; | ||
| .dark & { | ||
| box-shadow: 0 0 0 1px white; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
moved in line 294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.