[nextra-theme-blog]: fix Application error: a client-side exception has occurred when invalid date was provided in frontmatter + TESTS
#612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 679be4b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
dimaMachina
commented
Jul 29, 2022
| @@ -28,6 +28,7 @@ | |||
| "dev:tailwind": "cross-env TAILWIND_MODE=watch pnpm postcss src/styles.css -o style.css --watch", | |||
| "prepublishOnly": "pnpm build", | |||
| "clean": "rimraf ./dist ./style.css", | |||
| "test": "vitest run", | |||
There was a problem hiding this comment.
missing test script for blog cc @promer94
|
This is brilliant! Thanks @B2o5T. I never imagined that the date was the issue, and apparently safari didn't liked that date format. |
dimaMachina
force-pushed
the
fix-blog-date
branch
from
035b78b to
cb766b0
Compare
…has occurred` when invalid date was provided in frontmatter + TESTS
dimaMachina
force-pushed
the
fix-blog-date
branch
from
cb766b0 to
ed3bdd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #609
Dateconstructor in some browsers has different behaviourIn chrome follow date is valid:
https://github.com/numToStr/site/blob/8fef54ca4d778515cf94c8b277b1006774dd8a22/pages/blog/lsp-neovim-retrospective.mdx?plain=1#L4
But in Safari
This PR assert frontmatter date to be equal for the following formats:
cc @numToStr