fix(nextra): allow to contain dots in page filenames #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
dimaMachina
commented
Jul 16, 2022
packages/nextra/src/locales.ts
Outdated
Comment on lines
3
to
22
| const PUBLIC_FILE = /\.(.*)$/ | ||
|
|
||
| export function locales(request: NextRequest) { | ||
| const { nextUrl } = request | ||
|
|
||
| const shouldHandleLocale = | ||
| !PUBLIC_FILE.test(nextUrl.pathname) && | ||
| !nextUrl.pathname.includes('/api/') && | ||
| !nextUrl.pathname.includes('/_next/') && | ||
| !/^\/(api|_next)\//.test(nextUrl.pathname) && | ||
| !/\.(jpe?g|svg|png|webmanifest)$/.test(nextUrl.pathname) && |
There was a problem hiding this comment.
dimaMachina
commented
Jul 16, 2022
Comment on lines
-20
to
+18
| pageMaps: PageMapItem[], | ||
| pageMap: PageMapItem[], |
dimaMachina
commented
Jul 16, 2022
Comment on lines
+20
to
24
| export const parseJsonFile = ( | ||
| content: string, | ||
| path: string | ||
| ) => Record<string, any> = (content: string, path: string) => { | ||
| ): Record<string, any> => { | ||
| try { |
There was a problem hiding this comment.
can be simplified
🦋 Changeset detectedLatest commit: ba954cf The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Great refactor, thanks! |
tatukoivisto
pushed a commit
to tatukoivisto/nextra
that referenced
this pull request
Aug 20, 2023
* fix(nextra): allow to contain dots in page filenames * add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #545
getLocaleFromFilename,removeExtensionandgetFileNamein favor of simple and more genericparseFileNamefunctionparseFileNameto ensure it works like expectedlocales.ts,const PUBLIC_FILE = /\.(.*)$/not allow redirect page names with dots