the head config to support function in doc theme #410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shuding I was solving my issue described here #379, and I found what is the issue.
This PR will add a support for passing a function in
config.head
configuration for Docs theme.To support
config.head
as a function we need to have latest code fromcore
branch forrenderComponent
metod:Note that this is not a function we have in latest tag (
v2.0.0-beta.5
). ThefunctionOnly
is added later.Important part is we have
functionOnly
and in case it is true we returnComponentOrNode(props)
. And that is what will make config.head as a function to be rendered into the Head.Also we need to do what my PR suggest to call
renderComponent
with thefunctionOnly
=true
, because only in that case we will support both cases forconfig.head
: function and Element.Example of the
config.head
as a function we will support after this PR, and releasing new tag.