Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] allow items: Map for type: 'menu' since object can't guaranty the insertion order #2759

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

dimaMachina
Copy link
Collaborator

  • fix: Invalid webkit style

"-webkit-background-clip" is an invalid style for JSX, this commit switches this to the "WebkitBackgroundClip" style.

  • refactor: Remove webkit styling

caffeine-addictt and others added 5 commits February 29, 2024 14:29
* fix: Invalid webkit style

"-webkit-background-clip" is an invalid style for JSX, this commit switches this to the "WebkitBackgroundClip" style.

* refactor: Remove webkit styling
* fix: resolve memory leak issue in highlight-matches component

A critical update has been made to prevent potential infinite loops that could occur in certain scenarios, such as when a match is followed by two spaces and a character.

* refactor: apply simplified regex approach to resolve memory leak

* add changeset

---------

Co-authored-by: Dimitri POSTOLOV <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dimaMachina dimaMachina added this to the 3.0 milestone Mar 4, 2024
Copy link

changeset-bot bot commented Mar 4, 2024

🦋 Changeset detected

Latest commit: 1cf4215

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 4:18pm
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 4:18pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2024 4:18pm

Copy link
Contributor

github-actions bot commented Mar 4, 2024

📦 Next.js Bundle Analysis for swr-site

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 156.09 KB (🟡 +32 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seventy-seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/en 16.38 KB 172.47 KB 49.28% (🟡 +0.01%)
/en/about/a-page 8.32 KB 164.41 KB 46.97% (🟡 +0.02%)
/en/about/acknowledgement 8.32 KB 164.41 KB 46.97% (🟡 +0.02%)
/en/about/changelog 9.01 KB 165.11 KB 47.17% (🟡 +0.02%)
/en/about/team 8.37 KB 164.46 KB 46.99% (🟡 +0.01%)
/en/blog 9.11 KB 165.2 KB 47.20% (🟡 +0.01%)
/en/blog/swr-v1 13.69 KB 169.78 KB 48.51% (🟡 +0.01%)
/en/docs/404-500 9.16 KB 165.25 KB 47.22% (🟡 +0.01%)
/en/docs/advanced 8.69 KB 164.79 KB 47.08% (🟡 +0.02%)
/en/docs/advanced/cache 21.13 KB 177.22 KB 50.63% (🟡 +0.02%)
/en/docs/advanced/code-highlighting 9.25 KB 165.34 KB 47.24% (🟡 +0.01%)
/en/docs/advanced/dynamic-markdown-import 10.71 KB 166.8 KB 47.66% (🟡 +0.01%)
/en/docs/advanced/file-name.with.DOTS 8.35 KB 164.44 KB 46.98% (🟡 +0.02%)
/en/docs/advanced/images 8.8 KB 164.9 KB 47.11% (🟡 +0.02%)
/en/docs/advanced/markdown-import 16.7 KB 172.8 KB 49.37% (🟡 +0.01%)
/en/docs/advanced/more/loooooooooooooooooooong-title 8.44 KB 164.53 KB 47.01% (🟡 +0.01%)
/en/docs/advanced/more/tree/one 8.35 KB 164.45 KB 46.99% (🟡 +0.01%)
/en/docs/advanced/more/tree/three 8.32 KB 164.42 KB 46.98% (🟡 +0.01%)
/en/docs/advanced/more/tree/two 8.34 KB 164.43 KB 46.98% (🟡 +0.01%)
/en/docs/advanced/performance 10.74 KB 166.84 KB 47.67% (🟡 +0.01%)
/en/docs/advanced/react-native 10.82 KB 166.91 KB 47.69% (🟡 +0.01%)
/en/docs/advanced/scrollbar-x 13.12 KB 169.21 KB 48.35% (🟡 +0.01%)
/en/docs/arguments 10.16 KB 166.26 KB 47.50% (🟡 +0.02%)
/en/docs/callout 8.97 KB 165.06 KB 47.16% (🟡 +0.01%)
/en/docs/change-log 8.67 KB 164.76 KB 47.08% (🟡 +0.01%)
/en/docs/code-block-without-language 8.44 KB 164.54 KB 47.01% (🟡 +0.01%)
/en/docs/conditional-fetching 9.38 KB 165.47 KB 47.28% (🟡 +0.01%)
/en/docs/custom-header-ids 8.84 KB 164.93 KB 47.12% (🟡 +0.02%)
/en/docs/data-fetching 10.28 KB 166.37 KB 47.53% (🟡 +0.02%)
/en/docs/error-handling 11.1 KB 167.19 KB 47.77% (🟡 +0.01%)
/en/docs/getting-started 22.39 KB 178.49 KB 51.00% (🟡 +0.01%)
/en/docs/global-configuration 9.69 KB 165.79 KB 47.37% (🟡 +0.01%)
/en/docs/middleware 12.05 KB 168.14 KB 48.04% (🟡 +0.01%)
/en/docs/mutation 11.15 KB 167.24 KB 47.78% (🟡 +0.02%)
/en/docs/options 10.65 KB 166.74 KB 47.64% (🟡 +0.01%)
/en/docs/pagination 21.1 KB 177.2 KB 50.63% (🟡 +0.01%)
/en/docs/prefetching 9.85 KB 165.95 KB 47.41% (🟡 +0.02%)
/en/docs/raw-layout 9.04 KB 165.13 KB 47.18% (🟡 +0.01%)
/en/docs/revalidation 15.52 KB 171.61 KB 49.03% (🟡 +0.02%)
/en/docs/suspense 10.34 KB 166.43 KB 47.55% (🟡 +0.02%)
/en/docs/typescript 10.18 KB 166.28 KB 47.51% (🟡 +0.01%)
/en/docs/understanding 16.64 KB 172.74 KB 49.35% (🟡 +0.02%)
/en/docs/with-nextjs 10.54 KB 166.63 KB 47.61% (🟡 +0.01%)
/en/docs/wrap-toc-items 9.14 KB 165.23 KB 47.21% (🟡 +0.01%)
/en/examples/auth 8.58 KB 164.68 KB 47.05% (🟡 +0.01%)
/en/examples/basic 8.58 KB 164.67 KB 47.05% (🟡 +0.01%)
/en/examples/error-handling 8.59 KB 164.68 KB 47.05% (🟡 +0.02%)
/en/examples/full 8.57 KB 164.67 KB 47.05% (🟡 +0.01%)
/en/examples/infinite-loading 8.6 KB 164.69 KB 47.06% (🟡 +0.01%)
/en/examples/ssr 8.59 KB 164.69 KB 47.05% (🟡 +0.02%)
/en/foo 12.45 KB 168.54 KB 48.15% (🟡 +0.02%)
/en/remote/graphql-eslint/[[...slug]] 12.62 KB 168.71 KB 48.20% (🟡 +0.02%)
/en/remote/graphql-yoga/[[...slug]] 12.63 KB 168.73 KB 48.21% (🟡 +0.01%)
/en/test 8.57 KB 164.66 KB 47.05% (🟡 +0.01%)
/es 10.32 KB 166.41 KB 47.55% (🟡 +0.01%)
/es/docs/advanced/file-name.with.DOTS 6.27 KB 162.37 KB 46.39% (🟡 +0.01%)
/es/docs/advanced/performance 8.82 KB 164.92 KB 47.12% (🟡 +0.01%)
/es/docs/arguments 8.15 KB 164.24 KB 46.93% (🟡 +0.01%)
/es/docs/change-log 12.17 KB 168.26 KB 48.08% (🟡 +0.01%)
/es/docs/conditional-fetching 7.35 KB 163.44 KB 46.70% (🟡 +0.01%)
/es/docs/data-fetching 8.19 KB 164.29 KB 46.94% (🟡 +0.01%)
/es/docs/error-handling 9.12 KB 165.22 KB 47.20% (🟡 +0.02%)
/es/docs/getting-started 14.1 KB 170.19 KB 48.63% (🟡 +0.01%)
/es/docs/global-configuration 7.66 KB 163.75 KB 46.79% (🟡 +0.01%)
/es/docs/mutation 9.16 KB 165.25 KB 47.22% (🟡 +0.01%)
/es/docs/options 8.64 KB 164.74 KB 47.07% (🟡 +0.01%)
/es/docs/pagination 19.41 KB 175.5 KB 50.14% (🟡 +0.01%)
/es/docs/prefetching 7.82 KB 163.92 KB 46.83% (🟡 +0.01%)
/es/docs/revalidation 13.55 KB 169.64 KB 48.47% (🟡 +0.01%)
/es/docs/suspense 8.31 KB 164.4 KB 46.97% (🟡 +0.01%)
/es/docs/understanding 14.54 KB 170.64 KB 48.75% (🟡 +0.01%)
/es/docs/with-nextjs 8.53 KB 164.63 KB 47.04% (🟡 +0.01%)
/es/docs/wrap-toc-items 7.08 KB 163.18 KB 46.62% (🟡 +0.01%)
/es/examples/auth 6.48 KB 162.58 KB 46.45% (🟡 +0.01%)
/es/examples/basic 6.49 KB 162.58 KB 46.45% (🟡 +0.01%)
/es/examples/error-handling 6.49 KB 162.58 KB 46.45% (🟡 +0.01%)
/es/examples/infinite-loading 6.5 KB 162.59 KB 46.46% (🟡 +0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

📦 Next.js Bundle Analysis for docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 159.15 KB (🟢 36 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants