Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] fix invisible mobile menu after click on hamburger #2400

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

@dimaMachina dimaMachina added this to the 3.0 milestone Oct 8, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2023

🦋 Changeset detected

Latest commit: 9cd534a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra ❌ Failed (Inspect) Oct 8, 2023 7:29pm
nextra-theme-docs-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2023 7:29pm
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2023 7:29pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

📦 Next.js Bundle Analysis for swr-site

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 156.09 KB (🟡 +49 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Hundred Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/en 15.83 KB 171.92 KB 49.12% (+/- <0.01%)
/en/about/a-page 7.92 KB 164.02 KB 46.86% (+/- <0.01%)
/en/about/acknowledgement 7.92 KB 164.01 KB 46.86% (+/- <0.01%)
/en/about/changelog 8.6 KB 164.7 KB 47.06% (🟢 -0.01%)
/en/about/team 7.97 KB 164.06 KB 46.87% (+/- <0.01%)
/en/blog 8.65 KB 164.75 KB 47.07% (+/- <0.01%)
/en/blog/swr-v1 13.5 KB 169.59 KB 48.45% (+/- <0.01%)
/en/docs/404-500 8.72 KB 164.81 KB 47.09% (+/- <0.01%)
/en/docs/advanced 8.3 KB 164.39 KB 46.97% (+/- <0.01%)
/en/docs/advanced/cache 20.77 KB 176.87 KB 50.53% (+/- <0.01%)
/en/docs/advanced/code-highlighting 8.81 KB 164.9 KB 47.11% (+/- <0.01%)
/en/docs/advanced/dynamic-markdown-import 10.22 KB 166.31 KB 47.52% (🟢 -0.01%)
/en/docs/advanced/file-name.with.DOTS 7.95 KB 164.04 KB 46.87% (+/- <0.01%)
/en/docs/advanced/images 8.27 KB 164.37 KB 46.96% (+/- <0.01%)
/en/docs/advanced/markdown-import 16.14 KB 172.23 KB 49.21% (+/- <0.01%)
/en/docs/advanced/more/loooooooooooooooooooong-title 8.04 KB 164.14 KB 46.90% (🟢 -0.01%)
/en/docs/advanced/more/tree/one 7.94 KB 164.03 KB 46.87% (🟢 -0.01%)
/en/docs/advanced/more/tree/three 7.93 KB 164.02 KB 46.86% (+/- <0.01%)
/en/docs/advanced/more/tree/two 7.93 KB 164.02 KB 46.86% (+/- <0.01%)
/en/docs/advanced/performance 10.35 KB 166.44 KB 47.55% (+/- <0.01%)
/en/docs/advanced/react-native 10.41 KB 166.5 KB 47.57% (+/- <0.01%)
/en/docs/advanced/scrollbar-x 12.61 KB 168.7 KB 48.20% (+/- <0.01%)
/en/docs/arguments 9.75 KB 165.84 KB 47.38% (+/- <0.01%)
/en/docs/callout 8.56 KB 164.66 KB 47.04% (+/- <0.01%)
/en/docs/change-log 8.25 KB 164.35 KB 46.96% (🟢 -0.01%)
/en/docs/code-block-without-language 8.06 KB 164.15 KB 46.90% (+/- <0.01%)
/en/docs/conditional-fetching 8.97 KB 165.06 KB 47.16% (+/- <0.01%)
/en/docs/custom-header-ids 8.43 KB 164.52 KB 47.01% (🟢 -0.01%)
/en/docs/data-fetching 9.84 KB 165.94 KB 47.41% (+/- <0.01%)
/en/docs/error-handling 10.68 KB 166.78 KB 47.65% (+/- <0.01%)
/en/docs/getting-started 21.44 KB 177.54 KB 50.72% (+/- <0.01%)
/en/docs/global-configuration 9.28 KB 165.37 KB 47.25% (+/- <0.01%)
/en/docs/middleware 11.63 KB 167.72 KB 47.92% (+/- <0.01%)
/en/docs/mutation 10.74 KB 166.83 KB 47.67% (🟢 -0.01%)
/en/docs/options 10.25 KB 166.34 KB 47.53% (🟢 -0.01%)
/en/docs/pagination 20.71 KB 176.81 KB 50.52% (🟢 -0.01%)
/en/docs/prefetching 9.44 KB 165.53 KB 47.29% (+/- <0.01%)
/en/docs/raw-layout 8.64 KB 164.73 KB 47.07% (🟢 -0.01%)
/en/docs/revalidation 14.99 KB 171.08 KB 48.88% (+/- <0.01%)
/en/docs/suspense 9.93 KB 166.02 KB 47.43% (+/- <0.01%)
/en/docs/typescript 9.76 KB 165.86 KB 47.39% (🟢 -0.01%)
/en/docs/understanding 16.11 KB 172.21 KB 49.20% (+/- <0.01%)
/en/docs/with-nextjs 10.11 KB 166.2 KB 47.49% (🟢 -0.01%)
/en/docs/wrap-toc-items 8.75 KB 164.84 KB 47.10% (🟢 -0.01%)
/en/examples/auth 8.17 KB 164.27 KB 46.93% (+/- <0.01%)
/en/examples/basic 8.18 KB 164.27 KB 46.93% (+/- <0.01%)
/en/examples/error-handling 8.18 KB 164.28 KB 46.94% (🟢 -0.01%)
/en/examples/full 8.17 KB 164.26 KB 46.93% (+/- <0.01%)
/en/examples/infinite-loading 8.2 KB 164.29 KB 46.94% (+/- <0.01%)
/en/examples/ssr 8.19 KB 164.28 KB 46.94% (🟢 -0.01%)
/en/foo 11.98 KB 168.07 KB 48.02% (+/- <0.01%)
/en/remote/graphql-eslint/[[...slug]] 11.94 KB 168.03 KB 48.01% (+/- <0.01%)
/en/remote/graphql-yoga/[[...slug]] 11.95 KB 168.04 KB 48.01% (+/- <0.01%)
/en/test 8.15 KB 164.24 KB 46.93% (🟢 -0.01%)
/es 10.34 KB 166.44 KB 47.55% (+/- <0.01%)
/es/docs/advanced/file-name.with.DOTS 6.36 KB 162.45 KB 46.42% (🟢 -0.01%)
/es/docs/advanced/performance 8.92 KB 165.01 KB 47.15% (🟢 -0.01%)
/es/docs/arguments 8.21 KB 164.3 KB 46.94% (+/- <0.01%)
/es/docs/change-log 12.11 KB 168.2 KB 48.06% (🟢 -0.01%)
/es/docs/conditional-fetching 7.42 KB 163.51 KB 46.72% (+/- <0.01%)
/es/docs/data-fetching 8.26 KB 164.35 KB 46.96% (🟢 -0.01%)
/es/docs/error-handling 9.2 KB 165.3 KB 47.23% (🟢 -0.01%)
/es/docs/getting-started 14.08 KB 170.17 KB 48.62% (+/- <0.01%)
/es/docs/global-configuration 7.73 KB 163.83 KB 46.81% (🟢 -0.01%)
/es/docs/mutation 9.24 KB 165.33 KB 47.24% (🟢 -0.01%)
/es/docs/options 8.73 KB 164.83 KB 47.09% (+/- <0.01%)
/es/docs/pagination 19.51 KB 175.6 KB 50.17% (+/- <0.01%)
/es/docs/prefetching 7.89 KB 163.99 KB 46.85% (+/- <0.01%)
/es/docs/revalidation 13.5 KB 169.6 KB 48.46% (🟢 -0.01%)
/es/docs/suspense 8.38 KB 164.48 KB 46.99% (+/- <0.01%)
/es/docs/understanding 14.5 KB 170.59 KB 48.74% (+/- <0.01%)
/es/docs/with-nextjs 8.6 KB 164.69 KB 47.06% (🟢 -0.01%)
/es/docs/wrap-toc-items 7.17 KB 163.26 KB 46.65% (🟢 -0.01%)
/es/examples/auth 6.56 KB 162.66 KB 46.47% (+/- <0.01%)
/es/examples/basic 6.57 KB 162.66 KB 46.47% (+/- <0.01%)
/es/examples/error-handling 6.57 KB 162.67 KB 46.48% (🟢 -0.01%)
/es/examples/infinite-loading 6.58 KB 162.67 KB 46.48% (🟢 -0.01%)
/ru 10.95 KB 167.04 KB 47.73% (🟢 -0.01%)
/ru/blog 7.41 KB 163.5 KB 46.71% (+/- <0.01%)
/ru/blog/swr-v1 13.54 KB 169.63 KB 48.47% (🟢 -0.01%)
/ru/docs/advanced/cache 20.58 KB 176.67 KB 50.48% (🟢 -0.01%)
/ru/docs/advanced/file-name.with.DOTS 6.73 KB 162.83 KB 46.52% (+/- <0.01%)
/ru/docs/advanced/performance 9.71 KB 165.81 KB 47.37% (+/- <0.01%)
/ru/docs/advanced/react-native 9.56 KB 165.65 KB 47.33% (+/- <0.01%)
/ru/docs/arguments 8.74 KB 164.83 KB 47.10% (🟢 -0.01%)
/ru/docs/change-log 12.54 KB 168.64 KB 48.18% (+/- <0.01%)
/ru/docs/conditional-fetching 7.91 KB 164 KB 46.86% (🟢 -0.01%)
/ru/docs/data-fetching 8.79 KB 164.89 KB 47.11% (+/- <0.01%)
/ru/docs/error-handling 10 KB 166.09 KB 47.45% (+/- <0.01%)
/ru/docs/getting-started 15.01 KB 171.1 KB 48.89% (🟢 -0.01%)
/ru/docs/global-configuration 8.27 KB 164.37 KB 46.96% (+/- <0.01%)
/ru/docs/middleware 11.06 KB 167.15 KB 47.76% (+/- <0.01%)
/ru/docs/mutation 10.15 KB 166.25 KB 47.50% (+/- <0.01%)
/ru/docs/options 9.56 KB 165.65 KB 47.33% (+/- <0.01%)
/ru/docs/pagination 20.59 KB 176.68 KB 50.48% (+/- <0.01%)
/ru/docs/prefetching 8.51 KB 164.6 KB 47.03% (+/- <0.01%)
/ru/docs/revalidation 14.31 KB 170.41 KB 48.69% (🟢 -0.01%)
/ru/docs/suspense 9 KB 165.09 KB 47.17% (+/- <0.01%)
/ru/docs/understanding 14.9 KB 170.99 KB 48.85% (+/- <0.01%)
/ru/docs/with-nextjs 9.25 KB 165.34 KB 47.24% (+/- <0.01%)
/ru/docs/wrap-toc-items 7.54 KB 163.63 KB 46.75% (+/- <0.01%)
/ru/examples/auth 6.93 KB 163.03 KB 46.58% (+/- <0.01%)
/ru/examples/basic 6.94 KB 163.03 KB 46.58% (+/- <0.01%)
/ru/examples/error-handling 6.94 KB 163.04 KB 46.58% (+/- <0.01%)
/ru/examples/infinite-loading 6.95 KB 163.04 KB 46.58% (+/- <0.01%)
/ru/examples/ssr 6.95 KB 163.04 KB 46.58% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@dimaMachina dimaMachina merged commit b045cc3 into v3 Oct 8, 2023
@dimaMachina dimaMachina deleted the v3-42 branch October 8, 2023 19:38
@vordgi vordgi mentioned this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant