Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add themeswitch in blog theme #117

Closed
wants to merge 3 commits into from
Closed

Conversation

Djiit
Copy link

@Djiit Djiit commented Mar 30, 2021

Closes #115

@vercel
Copy link

vercel bot commented Mar 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nextra-dev – ./examples/docs

🔍 Inspect: https://vercel.com/shuding/nextra-dev/HShGkWqaBYk4TJqSNWrViwxkotGV
✅ Preview: https://nextra-dev-git-fork-djiit-feat-blog-darkmode-shuding1.vercel.app

nextra – ./

🔍 Inspect: https://vercel.com/shuding/nextra/DKRixtUpx5FTsgENPsZxGxeocAJB
✅ Preview: Failed

[Deployment for fe9fb06 failed]

@Djiit
Copy link
Author

Djiit commented Mar 30, 2021

Hey, this is a very naive implementation so I can get used to the packages and contrib workflow.

I'm clearly not a designer, so I'll need some help on defining some basic but solid variables for the blog "dark theme". In the last commit, I suggested some changes + extracted some .dark classes from the docs theme.

Some important facts :

  • Not sure of the overall dark theme (see above)
  • Same for the ThemeSwitch placement, any guidance is welcome
  • Not sure the "typography" is working well. Worth checking the complete example/blog app.
  • No docs... But that could be another PR as there is no "blog theme" docs for now.

Happy to discuss all of this! Cheers ;)

@Djiit Djiit marked this pull request as ready for review March 30, 2021 08:16
@LucaNerlich
Copy link

well, that was quick :) A bit unfortunate, that the vercel / gitlab preview integration points to the site theme in this case.
But keep up the good work 💪

@shuding
Copy link
Owner

shuding commented Apr 5, 2021

The new @tailwindcss/typography or tailwindcss is causing issue for me locally:

image

Seems all prose styles are missing.

@dimaMachina
Copy link
Collaborator

Closing as completed #242

@dimaMachina dimaMachina closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants