Ignore dimensions extraction errors by default

This was the default behaviour before we added the :on_error handler, so
we keep it. In Shrine 3.0 dimensions extraction exceptions will trigger
a warning by default.

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## HEAD
 
+* `store_dimensions` – Ignore dimensions extraction errors by default (@janko)
+
 * `file_system` – Un-deprecate `FileSystem#upload` receiving unrecognized options (@janko)
 
 ## 2.19.2 (2018-07-25)

lib/shrine/plugins/store_dimensions.rb

@@ -14,7 +14,7 @@ module StoreDimensions
       end
 
       def self.configure(uploader, opts = {})
-        uploader.opts[:store_dimensions] ||= { analyzer: :fastimage, on_error: :warn, log_subscriber: LOG_SUBSCRIBER }
+        uploader.opts[:store_dimensions] ||= { analyzer: :fastimage, on_error: :ignore, log_subscriber: LOG_SUBSCRIBER }
         uploader.opts[:store_dimensions].merge!(opts)
 
         # resolve error strategy

test/plugin/store_dimensions_test.rb

@@ -22,9 +22,7 @@
     end
 
     it "returns nil for non-images" do
-      assert_logged /SHRINE WARNING: Error occurred/ do
-        assert_nil @shrine.extract_dimensions(fakeio)
-      end
+      assert_nil @shrine.extract_dimensions(fakeio)
     end
   end
 
@@ -43,9 +41,7 @@
     end
 
     it "returns nil for non-images" do
-      assert_logged /SHRINE WARNING: Error occurred/ do
-        assert_nil @shrine.extract_dimensions(fakeio)
-      end
+      assert_nil @shrine.extract_dimensions(fakeio)
     end
   end unless ENV["CI"]
 
@@ -64,9 +60,7 @@
     end
 
     it "returns nil for non-images" do
-      assert_logged /SHRINE WARNING: Error occurred/ do
-        assert_nil @shrine.extract_dimensions(fakeio)
-      end
+      assert_nil @shrine.extract_dimensions(fakeio)
     end
   end unless ENV["CI"]