dc395x: uninitialized variable in device_alloc()

commit 208afec upstream. This bug was introduced back in bitkeeper days in 2003. We use "dcb->dev_mode" before it has been initialized. Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Oliver Neukum <[email protected]> Signed-off-by: James Bottomley <[email protected]> Signed-off-by: Ben Hutchings <[email protected]>
shr-distribution · Mar 20, 2013 · ae65176 · ae65176
1 parent 4dd30e2
commit ae65176
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
@@ -3747,13 +3747,13 @@ static struct DeviceCtlBlk *device_alloc(struct AdapterCtlBlk *acb,
 	dcb->max_command = 1;
 	dcb->target_id = target;
 	dcb->target_lun = lun;
+	dcb->dev_mode = eeprom->target[target].cfg0;
 #ifndef DC395x_NO_DISCONNECT
 	dcb->identify_msg =
 	    IDENTIFY(dcb->dev_mode & NTC_DO_DISCONNECT, lun);
 #else
 	dcb->identify_msg = IDENTIFY(0, lun);
 #endif
-	dcb->dev_mode = eeprom->target[target].cfg0;
 	dcb->inquiry7 = 0;
 	dcb->sync_mode = 0;
 	dcb->min_nego_period = clock_period[period_index];