Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shout.css #51

Merged
merged 2 commits into from
Nov 23, 2019
Merged

Update shout.css #51

merged 2 commits into from
Nov 23, 2019

Conversation

Kreezag
Copy link
Contributor

@Kreezag Kreezag commented Nov 20, 2019

Fix incorrect display of overflowing long text.
Идея реактивности — Реактивность Vue js 2019-11-20 12-24-36

Fix align long text in shout header.
Remove incorrect display of overflowing text.
@avdeev avdeev requested a review from pepelsbey November 20, 2019 09:29
@pepelsbey
Copy link
Contributor

Hmm, what am I doing wrong here and how exactly box-sizing: border-box would help?

When I type words with spaces they naturally break.

image

When the word is too long to fit it overflows

image

If you want them to break, you can add invisible ­ symbol that would break if the word won’t fit:

image

Adding box-sizing: border-box doesn’t help with overflowing words.

Copy link
Contributor

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure how exactly this would help.

@Kreezag
Copy link
Contributor Author

Kreezag commented Nov 23, 2019

Probably it's only my problem, but I see title offset in the list mode
CPU History 2019-11-23 15-40-21

Browser: Google Chrome 78.0.3904.97
System: mac OS Catalina

@pepelsbey
Copy link
Contributor

Oh my, I finally got it. Sorry it took a while. But a little explanation would’ve helped.
Thank you, I’m going to merge and release it shortly.

@pepelsbey pepelsbey merged commit 14e6180 into shower:master Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants