Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiero has added some resolver tokens in the last couple of versions. #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dashielb1010
Copy link

New tokens:

  • "_nameindex"
  • "ampm"
  • "filepath"
  • "hierotemp"
  • "hour12"
  • "hour24"
  • "minute"
  • "second"
  • "timestamp"

Tokens removed:

  • "ext"
  • "fullbinpath"

Hoping to use _nameindex in our template which is why this came up.

New tokens:
  + "_nameindex"
  + "ampm"
  + "filepath"
  + "hierotemp"
  + "hour12"
  + "hour24"
  + "minute"
  + "second"
  + "timestamp"

Tokens removed:
  - "ext"
  - "fullbinpath"

Hoping to use _nameindex in our template which is why this came up.
@josh-t
Copy link
Contributor

josh-t commented Dec 6, 2017

Hey @dashielb1010! Thanks for this. What's the behavior if someone is using an older version of hiero/ns that doesn't support the new tokens or wants to use the tokens that were removed? If we leave the old ones in there, would that still work?

@dashielb1010
Copy link
Author

dashielb1010 commented Dec 6, 2017

Hi @josh-t! It did occur to me afterward that the change is almost certainly not backwards-compatible, which of course your app goes to great lengths to be. I suspect it would break-- I'll revise when I can, cheers!

@josh-t
Copy link
Contributor

josh-t commented Dec 6, 2017

No worries @dashielb1010. We can leave this open for now if you want to commit additional changes to this branch. If not, feel free to close and we can evaluate on a different PR.

@dashielb1010
Copy link
Author

Keep it open, please. I'll do my updates on this branch. -Thx

  - "binpath"
  - "ext"
  - "fullbinpath"

Re-arranged the order of the exapnded list for easier matching against
future Nuke/NukeStudio/Hiero user-guides
@dashielb1010
Copy link
Author

Hi @josh-t, I think the last commit should take care of backwards compatibility. Of course, users that use tokens that are no longer available will be met with error messages during their exports for using the {ext}, {binpath}, and {fullbinpath} tokens in later versions, but at least the tokens list is fully inclusive as of 11.0v3 now.

By the way-- and this is a sidebar-- any idea why "projectroot" and "YYYY" are sorted before "project" and "YY" in Qt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants