Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add updated AppScript reference #1726

Open
wants to merge 1 commit into
base: next-6.7
Choose a base branch
from

Conversation

mstegmeyer
Copy link
Contributor

@mstegmeyer mstegmeyer commented Mar 19, 2025

This is all autogenerated content by platform. But it has diverged due to manual changes here in the repository. Making it up to date again.
Matching platform branch: shopware/shopware#8054

@mstegmeyer mstegmeyer self-assigned this Mar 19, 2025
@mstegmeyer mstegmeyer added Checkout @st-codebusters and removed Checkout @st-codebusters labels Mar 19, 2025
@mstegmeyer mstegmeyer force-pushed the chore/add-updated-app-script-script-reference branch from 6d45044 to 23e900e Compare March 27, 2025 10:17
@mstegmeyer
Copy link
Contributor Author

@Isengo1989 The general issue is, that these files are autogenerated by platform (https://github.com/shopware/shopware/blob/trunk/src/Core/DevOps/Docs/Script/ScriptReferenceGeneratorCommand.php), and you guys seem to have done manual changes here. The linter also doesn't manage to fix those issues. My theory is that one should align the Generation process instead of doing code changes here.

@mstegmeyer mstegmeyer requested a review from Isengo1989 March 27, 2025 10:28
@bojanrajh bojanrajh self-requested a review March 28, 2025 16:15
Copy link
Collaborator

@bojanrajh bojanrajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the deployment: https://github.com/shopware/developer-portal/actions/runs/14104149040/job/39506745478#step:8:53

{% raw %} tag was supported by Gitbook and was migrated to codeblocks.

@mstegmeyer mstegmeyer force-pushed the chore/add-updated-app-script-script-reference branch 3 times, most recently from b19775b to 2f9e8cc Compare March 29, 2025 10:43
@mstegmeyer mstegmeyer force-pushed the chore/add-updated-app-script-script-reference branch 6 times, most recently from e00ad77 to 10bfeb9 Compare March 29, 2025 11:23
@mstegmeyer mstegmeyer requested a review from bojanrajh March 29, 2025 11:23
@mstegmeyer mstegmeyer force-pushed the chore/add-updated-app-script-script-reference branch from 10bfeb9 to f03a9fd Compare March 29, 2025 11:27
@mstegmeyer mstegmeyer requested a review from cyl3x March 29, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants