Update path used in asset filter example #1714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschulzebaek
changed the title
Isengo1989
force-pushed
the
bschulzebaek-patch-1
branch
from
daa9110 to
727009b
Compare
|
@bschulzebaek Github did mix up smth I suppose. I changed the target branch to next-6.7, and after rebase, the PR is now crooked (adr changes that are not supposed to be there). If you want to recreate the PR with target "next-6.7" please do so, if you don't have time, I can take care of it. |
bschulzebaek
force-pushed
the
bschulzebaek-patch-1
branch
from
727009b to
354575c
Compare
No worries, fixed it with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the asset path used in the code example, this has changed during 6.7 / vite changes.
Also removed the warning about Vue filters, as our
assetFilter, which is described right above the warning is not an actual Vue filter and thus not affected by the deprecation - quite confusing. Devs should be able to learn about Vue 2 filter deprecation in their respective docs, which are linked or referred to throughout our upgrade guides anyway 💡