-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adjust performance tweaks for 6.7 update #1705
Conversation
#1675) * docs: enhance licensing and feature management information in commercial plugin * Apply suggestions from code review Co-authored-by: Micha Hobert <[email protected]> --------- Co-authored-by: Micha Hobert <[email protected]>
* feat: remove workflows * fix: guidelines * fix: guidelines * fix: lint
There was one class missing in the "use Symfony\Component\Console\Attribute\AsCommand" class, which is generating an error like the following: The command defined in "NameSpace\Of\MyClassCommand" cannot have an empty name.
"options:" does not exist anymore in config and was not removed here but later in the docs. This will result in an "access denied" error as soon as file system calls are made, despite valid credentials.
853306a
to
a52bf76
Compare
@Isengo1989 looks like the next-6.7 branch is not recent, do we wanna update that branch or should I remove the commits from main that are not in the branch from this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there seem to be some unrelated commits. not sure, if they are intentionally here
I suppose we can update the next-6.7 branch to be up 2 date with main, @bojanrajh was maintaining it so far, let's wait for his feedback ⏳ |
I just merged |
Let me just fix the markdown and spellcheck 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the PR @keulinho 🎉
No description provided.