Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adjust performance tweaks for 6.7 update #1705

Merged
merged 9 commits into from
Feb 26, 2025

Conversation

keulinho
Copy link
Contributor

No description provided.

shyim and others added 7 commits February 19, 2025 11:23
#1675)

* docs: enhance licensing and feature management information in commercial plugin

* Apply suggestions from code review

Co-authored-by: Micha Hobert <[email protected]>

---------

Co-authored-by: Micha Hobert <[email protected]>
* feat: remove workflows

* fix: guidelines

* fix: guidelines

* fix: lint
There was one class missing in the "use Symfony\Component\Console\Attribute\AsCommand" class, which is generating an error like the following:

The command defined in "NameSpace\Of\MyClassCommand" cannot have an empty name.
"options:" does not exist anymore in config and was not removed here but later in the docs. This will result in an "access denied" error as soon as file system calls are made, despite valid credentials.
@keulinho keulinho added this to the 6.7.0.0 milestone Feb 25, 2025
@keulinho keulinho self-assigned this Feb 25, 2025
@keulinho keulinho force-pushed the adjust-performance-tweaks-for-6-7 branch from 853306a to a52bf76 Compare February 25, 2025 15:01
@keulinho keulinho requested a review from AydinHassan February 25, 2025 15:01
@keulinho keulinho changed the base branch from main to next-6.7 February 25, 2025 15:02
@keulinho
Copy link
Contributor Author

@Isengo1989 looks like the next-6.7 branch is not recent, do we wanna update that branch or should I remove the commits from main that are not in the branch from this PR?

Copy link
Member

@mitelg mitelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there seem to be some unrelated commits. not sure, if they are intentionally here

@Isengo1989
Copy link
Collaborator

@Isengo1989 looks like the next-6.7 branch is not recent, do we wanna update that branch or should I remove the commits from main that are not in the branch from this PR?

I suppose we can update the next-6.7 branch to be up 2 date with main, @bojanrajh was maintaining it so far, let's wait for his feedback ⏳

@bojanrajh
Copy link
Collaborator

I just merged main into next-6.7, solved a conflict with new watcher hash in reverse http cache. I guess the PR is ready for a squash? :)

@Isengo1989
Copy link
Collaborator

I just merged main into next-6.7, solved a conflict with new watcher hash in reverse http cache. I guess the PR is ready for a squash? :)

Let me just fix the markdown and spellcheck 👋

Copy link
Collaborator

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR @keulinho 🎉

@keulinho keulinho merged commit d6e1603 into next-6.7 Feb 26, 2025
6 checks passed
@keulinho keulinho deleted the adjust-performance-tweaks-for-6-7 branch February 26, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants