Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getter for session tokens #45

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

benoit-apk
Copy link
Collaborator

No description provided.

@ddattee
Copy link
Contributor

ddattee commented Jun 20, 2018

Hi @benoit-apk,
thanks for contributing.
I was wondering what was the need behind retrieving the token ?
Everything seem ok to us it's just for understanding the reason behind this PR.
Thanks

@benoit-apk
Copy link
Collaborator Author

Hi,

Actually, we would like to provide the user with the possibility to create an account by entering the corresponding name and password, in case he wouldn't (yet) know which token to use.
This is mainly for the sake of completeness, but it could also save a bit of time for some merchants.

@ddattee ddattee self-assigned this Jun 20, 2018
@ddattee ddattee added the enhancement New feature or request label Jun 20, 2018
@ddattee
Copy link
Contributor

ddattee commented Jun 20, 2018

@benoit-apk
Ok thanks for the answer.

Can you continue testing on master branch ?
We would like to avoid doing too small releases if we can.

@ddattee ddattee merged commit 3687669 into shoppingflux:master Jun 20, 2018
@benoit-apk
Copy link
Collaborator Author

benoit-apk commented Jun 20, 2018

We can continue testing with the current release for now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants