Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InventoryUpdate - uniformisation with OrderOperation functionning #36

Merged
merged 8 commits into from
May 31, 2018

Conversation

ddattee
Copy link
Contributor

@ddattee ddattee commented May 22, 2018

This PR aim to standardize the use of InventoryUpdate based on OrderOperation functionning (cf. #13 (comment))

@ddattee ddattee self-assigned this May 22, 2018
@ddattee ddattee requested a review from ronan-gloo May 22, 2018 10:18
$inventoryUpdate
->add('ref1', 7)
->add('ref2', 1)
->execute($inventoryApi->getLink());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi avoir changé ça ? On garde le comportement précédent comme modèle

@ronan-gloo
Copy link
Contributor

I moved the Update operation object to the API, with its friends :)

0f31a48

@ddattee ddattee force-pushed the inventory-update branch from 0f31a48 to 445f430 Compare May 31, 2018 13:52
@ddattee
Copy link
Contributor Author

ddattee commented May 31, 2018

Oops sorry didn't see your commit before pushing.
I did the same so nothing's lost

@ddattee ddattee merged commit ff04149 into shoppingflux:develop May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants