Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] 14.0 cancel and redraft sale endpoint #907

Merged

Conversation

PierrickBrun
Copy link
Contributor

@sebastienbeau Can you review ?

@PierrickBrun PierrickBrun force-pushed the 14.0-cancel-modify-order branch from 39996e4 to adfa62d Compare March 3, 2021 12:56
@codecov-io
Copy link

codecov-io commented Mar 3, 2021

Codecov Report

Merging #907 (adfa62d) into 14.0 (2ce2a2d) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             14.0     #907      +/-   ##
==========================================
+ Coverage   91.61%   91.71%   +0.10%     
==========================================
  Files          78       79       +1     
  Lines        4780     4829      +49     
==========================================
+ Hits         4379     4429      +50     
+ Misses        401      400       -1     
Impacted Files Coverage Δ
shopinvader/services/sale.py 100.00% <100.00%> (ø)
shopinvader/tests/__init__.py 100.00% <100.00%> (ø)
shopinvader/tests/test_sale.py 100.00% <100.00%> (ø)
shopinvader/tests/test_sale_cancel.py 100.00% <100.00%> (ø)
shopinvader/models/sale.py 98.50% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce2a2d...cf79a2c. Read the comment docs.

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Some remarks

@PierrickBrun PierrickBrun force-pushed the 14.0-cancel-modify-order branch from 018da3f to de37465 Compare March 26, 2021 10:35
@sebastienbeau
Copy link
Contributor

@rousseldenis can you update your review

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot merge minor

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-907-by-rousseldenis-bump-minor, awaiting test results.

@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 63048ca. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants