Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][FWD] Add backend invoice options #781

Merged
merged 4 commits into from
Oct 7, 2020

Conversation

simahawk
Copy link
Contributor

@simahawk simahawk commented Sep 22, 2020

FWD port of #778

TODO once merged: backport improvemets to #778

In the current implementation only invoices linked to a sale order and
in a paid state can be downloaded by the customer.
As this can be limiting for some implementation, a configuration page is
added in the backend view with two options changing the scope of invoices
allowed for download :

    * Allow for open invoices
    * Disable the restriction on invoice being linked to sale order

By default those options are set so the current domain on invoices is
not changed.

Also a third option is added to the configuration to allow for selecting
a specific report to use for the pdf generation.
@simahawk
Copy link
Contributor Author

simahawk commented Oct 7, 2020

@lmignon would you have time for a review?

Copy link
Collaborator

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @simahawk LGTM (Code review).
A new nice feature!

@simahawk
Copy link
Contributor Author

simahawk commented Oct 7, 2020

/ocabot merge minor

@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-781-by-simahawk-bump-minor, awaiting test results.

@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 014d97c. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants