[10.0][IMP] shopinvader_promotion_rule: let possibility to disable promotion rule by backend #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rousseldenis
requested changes
Jul 31, 2020
lmignon
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
LGTM once comments from @rousseldenis are taken into account
acsonefho
force-pushed
the
10.0-shopinvader_promotion_rule_disabled
branch
from
248b30c to
0cb7dc6
Compare
|
This PR has the |
…omotion rule for specifics backends
acsonefho
force-pushed
the
10.0-shopinvader_promotion_rule_disabled
branch
from
0cb7dc6 to
8e45b43
Compare
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
77 tasks
|
Congratulations, your PR was merged at e705070. Thanks a lot for contributing to shopinvader. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a boolean on the backend to set if promotion rules should be applied or not.
The unit test only check the specific behavior.
The goal is not to test full
sale_promotion_rulemodule.