Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] add a wizard for redirecting the product or the category manually #682

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

sebastienbeau
Copy link
Contributor

Add a wizard in order to redirect easily

  • a product to an other product
  • a category to an other category

The redirection will inactive the binding and redirect the URL

@sebastienbeau sebastienbeau force-pushed the 10.0-redirect-wizard branch from 6e0406b to 5008be8 Compare May 28, 2020 16:49
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

Merging #682 into 10.0 will increase coverage by 0.04%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             10.0     #682      +/-   ##
==========================================
+ Coverage   90.54%   90.59%   +0.04%     
==========================================
  Files         152      153       +1     
  Lines        4104     4136      +32     
==========================================
+ Hits         3716     3747      +31     
- Misses        388      389       +1     
Impacted Files Coverage Δ
...pinvader/wizards/shopinvader_redirection_wizard.py 96.87% <96.87%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d880f6c...5008be8. Read the comment docs.

@Cedric-Pigeon Cedric-Pigeon mentioned this pull request Mar 26, 2021
77 tasks
@sebastienbeau
Copy link
Contributor Author

/ocabot merge nobump

@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 10.0-ocabot-merge-pr-682-by-sebastienbeau-bump-nobump, awaiting test results.

categ_ids = self._context["active_ids"]
products = self.env["product.template"].search(
[("categ_id", "=", categ_ids)]
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your test works, but shouldn't this be [("categ_id", "in", categ_ids)] instead?

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@shopinvader-git-bot shopinvader-git-bot merged commit 4e10054 into shopinvader:10.0 Mar 26, 2021
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at e8801a4. Thanks a lot for contributing to shopinvader. ❤️

@hparfr hparfr deleted the 10.0-redirect-wizard branch March 26, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants