Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][PORT] #622 port from 10.0: force technical user recompute export #677

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

HviorForgeFlow
Copy link
Contributor

Port #622 from 10.0 to 12.0

@rousseldenis rousseldenis added this to the 12.0 milestone May 27, 2020
@rousseldenis
Copy link
Contributor

@HviorForgeFlow We use MQT_PIP for tests in shopinvader (it can be activated for OCA too at demand).

So, you don't need to change oca_dependencies.txt as it wouldn't be taken into account as travis uses pip install -r test-requirements.txt in that case.

More flexible.

@HviorForgeFlow
Copy link
Contributor Author

HviorForgeFlow commented May 28, 2020

I can't guess how to add to addons in a PR inside test-requirements.txt
@rousseldenis what I should do?

Update: I think I found the way :)

Update 2: Something is still missing :(

@HviorForgeFlow HviorForgeFlow force-pushed the 12.0-622-port branch 2 times, most recently from 781809e to f1635a2 Compare May 28, 2020 08:26
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020

Codecov Report

Merging #677 into 12.0 will decrease coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0     #677      +/-   ##
==========================================
- Coverage   91.09%   91.01%   -0.08%     
==========================================
  Files         137      137              
  Lines        3997     3997              
==========================================
- Hits         3641     3638       -3     
- Misses        356      359       +3     
Impacted Files Coverage Δ
...nvader_search_engine/models/shopinvader_backend.py 38.88% <50.00%> (ø)
shopinvader/models/product_template.py 82.35% <0.00%> (-2.95%) ⬇️
shopinvader/models/shopinvader_product.py 86.86% <0.00%> (-2.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66bcda4...b576919. Read the comment docs.

@rousseldenis
Copy link
Contributor

@HviorForgeFlow Can you remove test requirement line and rebase ?

@rousseldenis
Copy link
Contributor

/ocabot merge minor

@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-677-by-rousseldenis-bump-minor, awaiting test results.

@lmignon lmignon mentioned this pull request Jun 8, 2020
77 tasks
@shopinvader-git-bot shopinvader-git-bot merged commit 346de48 into shopinvader:12.0 Jun 8, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 7e50510. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants