[12.0][PORT] #568 from 10.0: Fix shopinvader - Variants/Product active/inactive #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated to a shopinvader product are disabled, this shop. product is also disabled (active = False). But when the shopinvader variant is re-enabled, we should also re-enable the related shop. product (active = True). Otherwise it could cause some trouble into url management (url.url) who could stay disabled. But it's a side effect
Codecov Report
@@ Coverage Diff @@
## 12.0 #656 +/- ##
==========================================
+ Coverage 91.60% 91.66% +0.05%
==========================================
Files 137 137
Lines 3907 3921 +14
==========================================
+ Hits 3579 3594 +15
+ Misses 328 327 -1
Continue to review full report at Codecov.
|
rousseldenis
approved these changes
May 29, 2020
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 6d02094. Thanks a lot for contributing to shopinvader. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #568 from 10.0 to 12.0.