Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][PORT] #595 from 10.0: [FIX] fix database transaction error on multi-languages anonymous carts #650

Merged
merged 1 commit into from
Jun 3, 2020
Merged

[13.0][PORT] #595 from 10.0: [FIX] fix database transaction error on multi-languages anonymous carts #650

merged 1 commit into from
Jun 3, 2020

Conversation

HviorForgeFlow
Copy link
Contributor

Port #595 from 10.0 to 13.0.

@rousseldenis rousseldenis added this to the 13.0 milestone May 20, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020 •
edited
Loading

Codecov Report

Merging #650 into 13.0 will decrease coverage by 0.16%.
The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             13.0     #650      +/-   ##
==========================================
- Coverage   89.95%   89.78%   -0.17%     
==========================================
  Files         108      108              
  Lines        3513     3524      +11     
==========================================
+ Hits         3160     3164       +4     
- Misses        353      360       +7
Impacted Files Coverage Δ
shopinvader/services/cart.py 85.44% <36.36%> (-2.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11481df...20c365d. Read the comment docs.

sebastienbeau
sebastienbeau approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ocabot merge minor

@sebastienbeau
Copy link
Contributor

/ocabot merge minor

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-650-by-sebastienbeau-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request May 29, 2020
Merge PR #650 into 13.0
eb1fd6c 
Signed-off-by sebastienbeau
@rousseldenis
Copy link
Contributor

/ocabot merge minor

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-650-by-rousseldenis-bump-minor, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 87fd4de into shopinvader:13.0 Jun 3, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 2369bdf. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon mentioned this pull request Jun 3, 2020
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienbeau sebastienbeau sebastienbeau approved these changes

Assignees
No one assigned
Labels
forwardport merged 🎉 needs review
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@HviorForgeFlow @codecov-commenter @sebastienbeau @shopinvader-git-bot @rousseldenis