Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][PORT] #577 from 10.0: Fix missing parameters into some search validator #639

Merged
merged 1 commit into from
May 25, 2020

Conversation

HviorForgeFlow
Copy link
Contributor

Port #577 from 10.0 to 13.0.

@rousseldenis
Copy link
Contributor

@HviorForgeFlow Could you rebase ?

@rousseldenis
Copy link
Contributor

Don't forget the 12.0 PR too

@HviorForgeFlow HviorForgeFlow changed the title [13.0][PORT] 577 from 10.0 [13.0][PORT] #577 from 10.0: Fix missing parameters into some search validator May 18, 2020
…g parameters, it was not possible to use the pagination. To fix this, I just create a default search validator in service.py. This validator is not loaded into every service by default to stay compatible (about security) with existing parameters available
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (13.0@138c050). Click here to learn what that means.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##             13.0     #639   +/-   ##
=======================================
  Coverage        ?   89.92%           
=======================================
  Files           ?      108           
  Lines           ?     3502           
  Branches        ?        0           
=======================================
  Hits            ?     3149           
  Misses          ?      353           
  Partials        ?        0           
Impacted Files Coverage Δ
shopinvader/services/sale.py 91.11% <0.00%> (ø)
shopinvader/services/address.py 93.42% <100.00%> (ø)
shopinvader/services/service.py 77.77% <100.00%> (ø)
shopinvader_delivery_carrier/services/delivery.py 94.91% <100.00%> (ø)
shopinvader/models/shopinvader_backend.py 86.74% <0.00%> (ø)
...hopinvader_customer_multi_user/controllers/main.py 42.85% <0.00%> (ø)
...pinvader_cart_expiry/models/shopinvader_backend.py 100.00% <0.00%> (ø)
shopinvader/models/seo_title_mixin.py 100.00% <0.00%> (ø)
shopinvader/components/partner_validator.py 74.54% <0.00%> (ø)
... and 102 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138c050...5ecf4b2. Read the comment docs.

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-639-by-rousseldenis-bump-patch, awaiting test results.

@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at cf060e3. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants