-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][PORT] #577 from 10.0: Fix missing parameters into some search validator #639
Conversation
@HviorForgeFlow Could you rebase ? |
Don't forget the 12.0 PR too |
80b6b55
to
a78e777
Compare
a78e777
to
2a9001c
Compare
…g parameters, it was not possible to use the pagination. To fix this, I just create a default search validator in service.py. This validator is not loaded into every service by default to stay compatible (about security) with existing parameters available
2a9001c
to
5ecf4b2
Compare
Codecov Report
@@ Coverage Diff @@
## 13.0 #639 +/- ##
=======================================
Coverage ? 89.92%
=======================================
Files ? 108
Lines ? 3502
Branches ? 0
=======================================
Hits ? 3149
Misses ? 353
Partials ? 0
Continue to review full report at Codecov.
|
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at cf060e3. Thanks a lot for contributing to shopinvader. ❤️ |
Port #577 from 10.0 to 13.0.