Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] 12.0 shopinvader_sale_profile #633

Merged
merged 5 commits into from
May 20, 2020
Merged

[MIG] 12.0 shopinvader_sale_profile #633

merged 5 commits into from
May 20, 2020

Conversation

PierrickBrun
Copy link
Contributor

No description provided.

sebastienbeau and others added 5 commits May 7, 2020 19:31
@sebastienbeau
[FIX] fix error during the migration of the module, the key for locom…
fec28cd 
…otive is role and not sale_profile
[UPD] README.rst
24a111f
@rousseldenis
[10.0][FIX] shopinvader_sale_profile: Export default if no profile
a33ae62 
If we install shopinvader_sale_profile without activating sale profiles and
creating partners, they are exported with a role == false. This fixes it.
shopinvader_sale_profile 10.0.1.0.2
06a347b
[MIG] 12.0 sale_profile
f56be4b
@PierrickBrun PierrickBrun force-pushed the 12.0-mig-sale_profile branch from aa684be to f56be4b Compare May 7, 2020 18:12
rousseldenis
rousseldenis reviewed May 18, 2020
View reviewed changes
shopinvader_sale_profile/views/res_partner.xml
@@ -10,7 +10,7 @@
<field name="priority" eval="90"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='shopinvader_bind_ids']//tree" position="inside">
<field name="sale_profile_id"/>
<field name="sale_profile_id" readonly="1"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PierrickBrun Why changing this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the user shouldn't change the sale_profile directly, it will be calculated from the pricelist and the fiscal classification.
They are not tempted if the field can"t be edited

rousseldenis
rousseldenis approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-633-by-rousseldenis-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request May 20, 2020
Merge PR #633 into 12.0
3be4b95 
Signed-off-by rousseldenis
@rousseldenis
Copy link
Contributor

/ocabot merge patch

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-633-by-rousseldenis-bump-patch, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 096a7bc into shopinvader:12.0 May 20, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 9b3475e. Thanks a lot for contributing to shopinvader. ❤️

@sebastienbeau sebastienbeau mentioned this pull request Aug 31, 2020
Merged
@lmignon lmignon mentioned this pull request Aug 31, 2020
Closed
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hparfr hparfr hparfr approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
12.0 approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PierrickBrun @shopinvader-git-bot @rousseldenis @hparfr @sebastienbeau