Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][IMP] shopinvader_locomotive: Improve metadata #627

Conversation

rousseldenis
Copy link
Contributor

Sometimes, it would be necessary to have country states synchronized
with locomotive (e.g.: to manage more accurately deliveries)

@rousseldenis
Copy link
Contributor Author

@Cedric-Pigeon

@rousseldenis rousseldenis added this to the 10.0 milestone May 4, 2020
@Cedric-Pigeon
Copy link

@rousseldenis just one remark. I think we should update the customer and addresses services to use this value isn't it ?

Sometimes, it would be necessary to have country states synchronized
with locomotive (e.g.: to manage more accurately deliveries)
@rousseldenis rousseldenis force-pushed the 10.0-imp-shopinvader_locomotive_states-dro branch from 92453a8 to e333083 Compare May 4, 2020 09:18
@codecov-io
Copy link

codecov-io commented May 4, 2020

Codecov Report

Merging #627 into 10.0 will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             10.0     #627   +/-   ##
=======================================
  Coverage   90.45%   90.46%           
=======================================
  Files         151      151           
  Lines        4054     4057    +3     
=======================================
+ Hits         3667     3670    +3     
  Misses        387      387           
Impacted Files Coverage Δ
shopinvader_locomotive/component/mapper.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fb288e...e333083. Read the comment docs.

@rousseldenis
Copy link
Contributor Author

@rousseldenis just one remark. I think we should update the customer and addresses services to use this value isn't it ?

Nope. Already managed : https://github.com/shopinvader/odoo-shopinvader/blob/12.0/shopinvader/services/address.py#L75

@Cedric-Pigeon Cedric-Pigeon self-requested a review May 4, 2020 12:08
@sebastienbeau
Copy link
Contributor

/ocabot merge minor

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 10.0-ocabot-merge-pr-627-by-sebastienbeau-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request May 8, 2020
Signed-off-by sebastienbeau
@lmignon lmignon mentioned this pull request May 8, 2020
77 tasks
@shopinvader-git-bot
Copy link

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-627-by-sebastienbeau-bump-minor, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 17c5522 into shopinvader:10.0 May 8, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 33c4601. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants