-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0][IMP] shopinvader_locomotive: Improve metadata #627
[10.0][IMP] shopinvader_locomotive: Improve metadata #627
Conversation
@rousseldenis just one remark. I think we should update the customer and addresses services to use this value isn't it ? |
Sometimes, it would be necessary to have country states synchronized with locomotive (e.g.: to manage more accurately deliveries)
92453a8
to
e333083
Compare
Codecov Report
@@ Coverage Diff @@
## 10.0 #627 +/- ##
=======================================
Coverage 90.45% 90.46%
=======================================
Files 151 151
Lines 4054 4057 +3
=======================================
+ Hits 3667 3670 +3
Misses 387 387
Continue to review full report at Codecov.
|
Nope. Already managed : https://github.com/shopinvader/odoo-shopinvader/blob/12.0/shopinvader/services/address.py#L75 |
/ocabot merge minor |
This PR looks fantastic, let's merge it! |
It looks like something changed on |
Congratulations, your PR was merged at 33c4601. Thanks a lot for contributing to shopinvader. ❤️ |
Sometimes, it would be necessary to have country states synchronized
with locomotive (e.g.: to manage more accurately deliveries)