Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][FIX] shopinvader: sale service should return so linked to child partners #621

Merged
merged 1 commit into from
May 20, 2020

Conversation

Cedric-Pigeon
Copy link

TO secure delivery address, it is recommended to use partner_address_version and sale_partner_version addons which will archive the address used on confirmed version.

If the customer has only one address and updates, the address will be copied and set as a child of a new one (with updates). Without this pull request, the customer won't be able to see its order anymore because the partner_id on the confirmed So has been changed.

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense :)

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 10.0-ocabot-merge-pr-621-by-rousseldenis-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request May 20, 2020
Signed-off-by rousseldenis
@lmignon lmignon mentioned this pull request May 20, 2020
77 tasks
@rousseldenis
Copy link
Contributor

/ocabot merge patch

@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 10.0-ocabot-merge-pr-621-by-rousseldenis-bump-patch, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 5f6e51d into shopinvader:10.0 May 20, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at bb6810f. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants