Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][CHG] being able to make the difference between an update done by the customer and update done internally in Odoo #596

Merged
merged 1 commit into from
Mar 23, 2020
Merged

[10.0][CHG] being able to make the difference between an update done by the customer and update done internally in Odoo #596

merged 1 commit into from
Mar 23, 2020

Conversation

Cedric-Pigeon
Copy link

refers to #590

@Cedric-Pigeon Cedric-Pigeon mentioned this pull request Mar 20, 2020
Closed
sebastienbeau
sebastienbeau approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review
thanks for the improvement

simahawk
simahawk requested changes Mar 22, 2020
View reviewed changes
@Cedric-Pigeon Cedric-Pigeon force-pushed the 10.0-rest-update-cpi branch 3 times, most recently from 6d2b49f to 3ebb393 Compare March 23, 2020 06:26
@codecov-io
Copy link

codecov-io commented Mar 23, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (10.0@a4f7eb8). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             10.0     #596   +/-   ##
=======================================
  Coverage        ?   90.57%           
=======================================
  Files           ?      148           
  Lines           ?     3935           
  Branches        ?        0           
=======================================
  Hits            ?     3564           
  Misses          ?      371           
  Partials        ?        0
Impacted Files Coverage Δ
...pinvader_cart_expiry/models/shopinvader_backend.py 100% <ø> (ø)
...invader_pending_cart_reminder/models/sale_order.py 90.32% <ø> (ø)
shopinvader/models/sale.py 96.07% <100%> (ø)
shopinvader/services/service.py 85.86% <100%> (ø)
shopinvader/models/track_external_update.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f7eb8...76c3042. Read the comment docs.

simahawk
simahawk approved these changes Mar 23, 2020
View reviewed changes
acsonefho
acsonefho approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@acsonefho acsonefho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review! Seems great!

[10.0][CHG] being able to make the difference between an update done …
76c3042 
…by the customer and update done internally in Odoo
@rousseldenis
Copy link
Contributor

/ocabot merge minor

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 10.0-ocabot-merge-pr-596-by-rousseldenis-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Mar 23, 2020
Merge PR #596 into 10.0
ba48ff0 
Signed-off-by rousseldenis
@lmignon lmignon mentioned this pull request Mar 23, 2020
Closed
77 tasks
@shopinvader-git-bot
Copy link

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-596-by-rousseldenis-bump-minor, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 65b6688 into shopinvader:10.0 Mar 23, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at ee50511. Thanks a lot for contributing to shopinvader. ❤️

@HviorForgeFlow HviorForgeFlow mentioned this pull request May 26, 2020
Closed
acsonefho added a commit to acsone/odoo-shopinvader that referenced this pull request Oct 22, 2021
@acsonefho
[14.0][FWP] Forward port of shopinvader#596: make difference between …
b8affa5 
…update done by customer and internally in Odoo
@acsonefho acsonefho mentioned this pull request Oct 22, 2021
Merged
acsonefho added a commit to acsone/odoo-shopinvader that referenced this pull request Oct 22, 2021
@acsonefho
[14.0][FWP] Forward port of shopinvader#596: pre-commit + python 3 + …
2d3152c 
…small improvements
acsonefho added a commit to acsone/odoo-shopinvader that referenced this pull request Oct 25, 2021
@acsonefho
[14.0][FWP] Forward port of shopinvader#596: pre-commit + python 3 + …
cb82229 
…small improvements
acsonefho added a commit to acsone/odoo-shopinvader that referenced this pull request May 11, 2022
@acsonefho
[14.0][FWP] Forward port of shopinvader#596: pre-commit + python 3 + …
902ca61 
…small improvements
acsonefho added a commit to acsone/odoo-shopinvader that referenced this pull request May 12, 2022
@acsonefho
[14.0][FWP] Forward port of shopinvader#596: pre-commit + python 3 + …
da58951 
…small improvements
acsonefho added a commit to acsone/odoo-shopinvader that referenced this pull request May 12, 2022
@acsonefho
[14.0][FWP] Forward port of shopinvader#596: pre-commit + python 3 + …
90815e7 
…small improvements
acsonefho added a commit to acsone/odoo-shopinvader that referenced this pull request Jan 12, 2023
@acsonefho
[14.0][FWP] Forward port of shopinvader#596: pre-commit + python 3 + …
b12cc93 
…small improvements
acsonefho added a commit to acsone/odoo-shopinvader that referenced this pull request Jun 14, 2023
@acsonefho
[14.0][FWP] Forward port of shopinvader#596: pre-commit + python 3 + …
df940e7 
…small improvements
paradoxxxzero pushed a commit to akretion/odoo-shopinvader that referenced this pull request Jun 20, 2023
@acsonefho @paradoxxxzero
[14.0][FWP] Forward port of shopinvader#596: pre-commit + python 3 + …
afa0b9b 
…small improvements
paradoxxxzero pushed a commit to akretion/odoo-shopinvader that referenced this pull request Jun 20, 2023
@acsonefho @paradoxxxzero
[14.0][FWP] Forward port of shopinvader#596: pre-commit + python 3 + …
fa77317 
…small improvements
qgroulard pushed a commit to acsone/odoo-shopinvader that referenced this pull request Jul 28, 2023
@acsonefho @qgroulard
[14.0][FWP] Forward port of shopinvader#596: pre-commit + python 3 + …
2b4df34 
…small improvements
qgroulard pushed a commit to acsone/odoo-shopinvader that referenced this pull request Aug 10, 2023
@acsonefho @qgroulard
[14.0][FWP] Forward port of shopinvader#596: pre-commit + python 3 + …
306b98f 
…small improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@sebastienbeau sebastienbeau sebastienbeau approved these changes

@acsonefho acsonefho acsonefho approved these changes

@lmignon lmignon Awaiting requested review from lmignon

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Cedric-Pigeon @codecov-io @rousseldenis @shopinvader-git-bot @simahawk @sebastienbeau @acsonefho