[12.0][FIX] shopinvader guest mode export #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
approved these changes
Oct 30, 2019
|
|
||
|
|
||
| class TestShopinvaderPartnerGuest(CommonShopinvaderPartner): | ||
| def setUp(self, *args, **kwargs): |
There was a problem hiding this comment.
not blocking here but we should stop putting global create/write on setUp -> we get tons of DB operations that are not needed for every single test ;)
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
shopinvader-git-bot
pushed a commit
that referenced
this pull request
Oct 30, 2019
|
Congratulations, your PR was merged at 3f9eb1d. Thanks a lot for contributing to shopinvader. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foward port of #465