[12.0][ADD] Add delivery service #479
Conversation
There was a problem hiding this comment.
LG. Minor changes for tests, no blockers.
@lmignon additional consideration for this and other modules: we should include in README some documentation on the usage and the behavior of the rest endpoints in regards of the client (locomotive basically but better if generic).
Something like: "on your website client you can call this service like $snippet and you have to configure $this and take care of $that."
This is especially true for important changes like the one that happened on payments "this change requires you update you client template like $this and change $that" etc.
I mean, I know that the client should have its own docs but the functionalities are declared server side as well as the way someone should interact w/ them. IMO we must have some generic client-oriented documentation in each module. What do you think?
| for current_data, picking in zip(data, pickings): | ||
| carrier_dict = current_data.get("carrier", {}) | ||
| sale_dict = current_data.get("sale", {}) | ||
| self.assertEquals(current_data.get("delivery_id"), picking.id) |
There was a problem hiding this comment.
assertEquals is sort of deprecated in py3, use assertEqual
| self.assertEquals( | ||
| sale_dict.get("state"), picking.sale_id.state | ||
| ) | ||
| self.assertAlmostEquals( |
| partner=self.service.partner, sale=True | ||
| ) | ||
| pickings = picking1 | picking2 | picking3 | picking4 | ||
| self.assertEquals(picking1.partner_id, self.service.partner) |
There was a problem hiding this comment.
these assertions seem superfluous as you've just created the pickings w/ this partner
@simahawk I fully agree with you. It's the most important missing part of this project. We must also provide a clear changelog. I would like to start using towncrier to manage the changelog. @sbidoul plan to run towncrier in the bumpversion step of "ocabot merge" to generate the changelog OCA/maintainer-tools#432 |
Codecov Report
@@ Coverage Diff @@
## 12.0 #479 +/- ##
==========================================
- Coverage 91.35% 39.46% -51.9%
==========================================
Files 105 41 -64
Lines 2926 1746 -1180
==========================================
- Hits 2673 689 -1984
- Misses 253 1057 +804
Continue to review full report at Codecov.
|
lmignon
force-pushed
the
12.0-shopinvader_delivery_service
branch
from
5fb0ba2 to
3884530
Compare
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 34d8baa. Thanks a lot for contributing to shopinvader. ❤️ |
Forward port of #325
requires OCA/server-tools#1711