Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][FIX] action server in tree view must play on all selected records #458

Merged

Conversation

bguillot
Copy link
Contributor

@bguillot bguillot commented Oct 8, 2019

Hi,

The action server in tree view works only on the first selected record.

The PR fixes it.

Copy link
Contributor

@acsonefho acsonefho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

for template in object:
for template in records:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this code should no work... template is never used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thats right, it's luck that my patch fixed the bug ...
I will fix it.

@rousseldenis
Copy link
Contributor

@bguillot

@rousseldenis
Copy link
Contributor

@bguillot Any news ?

@sebastienbeau sebastienbeau changed the title [FIX] action server in tree view must play on all selected records [10.0][FIX] action server in tree view must play on all selected records May 1, 2020
@sebastienbeau sebastienbeau force-pushed the 10.0-fix-recompute-action-server branch from e45e12c to 85fe8dc Compare May 1, 2020 14:58
@codecov-io
Copy link

Codecov Report

Merging #458 into 10.0 will decrease coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             10.0     #458      +/-   ##
==========================================
- Coverage   90.45%   89.38%   -1.07%     
==========================================
  Files         151      136      -15     
  Lines        4054     3542     -512     
==========================================
- Hits         3667     3166     -501     
+ Misses        387      376      -11     
Impacted Files Coverage Δ
...ocomotive_reset_password/wizards/reset_password.py 47.82% <0.00%> (-48.85%) ⬇️
...le/components/shopinvader_partner_export_mapper.py 83.33% <0.00%> (-16.67%) ⬇️
shopinvader/services/service.py 76.00% <0.00%> (-9.87%) ⬇️
...e/component/shopinvader_binging_event_listeners.py 85.71% <0.00%> (-7.15%) ⬇️
shopinvader/shopinvader_response.py 93.33% <0.00%> (-6.67%) ⬇️
shopinvader/services/cart.py 87.81% <0.00%> (-3.03%) ⬇️
shopinvader/controllers/main.py 37.14% <0.00%> (-2.86%) ⬇️
shopinvader_invoice/services/invoice.py 97.50% <0.00%> (-2.50%) ⬇️
shopinvader/services/abstract_sale.py 97.56% <0.00%> (-2.44%) ⬇️
shopinvader/services/address.py 93.44% <0.00%> (-2.21%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fb288e...85fe8dc. Read the comment docs.

@sebastienbeau
Copy link
Contributor

I have rebased the work and added a test so it's ready for merging

@sebastienbeau
Copy link
Contributor

/ocabot merge minor

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 10.0-ocabot-merge-pr-458-by-sebastienbeau-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request May 4, 2020
Signed-off-by sebastienbeau
@lmignon lmignon mentioned this pull request May 4, 2020
77 tasks
@shopinvader-git-bot
Copy link

@sebastienbeau The merge process could not start, because command `git merge --no-ff -m Merge PR #458 into 10.0

Signed-off-by sebastienbeau tmp-pr-458` failed with output:

Auto-merging shopinvader_search_engine/tests/__init__.py
CONFLICT (add/add): Merge conflict in shopinvader_search_engine/tests/__init__.py
Automatic merge failed; fix conflicts and then commit the result.

@shopinvader-git-bot
Copy link

@sebastienbeau The merge process could not be finalized, because command `git merge --no-ff -m Merge PR #458 into 10.0

Signed-off-by sebastienbeau tmp-pr-458` failed with output:

Auto-merging shopinvader_search_engine/tests/__init__.py
CONFLICT (add/add): Merge conflict in shopinvader_search_engine/tests/__init__.py
Automatic merge failed; fix conflicts and then commit the result.

@rousseldenis
Copy link
Contributor

@bguillot Could you fix conflict ?

@bguillot bguillot force-pushed the 10.0-fix-recompute-action-server branch from 85fe8dc to be844c5 Compare May 19, 2020 07:37
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (10.0@084d5bd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             10.0     #458   +/-   ##
=======================================
  Coverage        ?   90.50%           
=======================================
  Files           ?      151           
  Lines           ?     4064           
  Branches        ?        0           
=======================================
  Hits            ?     3678           
  Misses          ?      386           
  Partials        ?        0           
Impacted Files Coverage Δ
...le/components/shopinvader_partner_export_mapper.py 100.00% <0.00%> (ø)
shopinvader/services/address.py 95.65% <0.00%> (ø)
...nvader_delivery_carrier/models/delivery_carrier.py 100.00% <0.00%> (ø)
shopinvader/services/customer.py 89.47% <0.00%> (ø)
shopinvader/models/shopinvader_variant.py 98.24% <0.00%> (ø)
shopinvader_algolia/components/deleter.py 100.00% <0.00%> (ø)
shopinvader_lead/services/lead.py 96.00% <0.00%> (ø)
...r/wizards/shopinvader_category_unbinding_wizard.py 92.30% <0.00%> (ø)
shopinvader/models/seo_title_mixin.py 100.00% <0.00%> (ø)
shopinvader_product_new/models/product_template.py 100.00% <0.00%> (ø)
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084d5bd...32157fe. Read the comment docs.

@rousseldenis
Copy link
Contributor

@lmignon Could you update your review ?

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@lmignon
Copy link
Collaborator

lmignon commented May 25, 2020

/ocabot merge patch

@shopinvader-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 10.0-ocabot-merge-pr-458-by-lmignon-bump-patch, awaiting test results.

@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 8076961. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants