[12.0][FW] Shopinvader clear cart #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acsonefho
force-pushed
the
12.0-fw_shopinvader-clear_cart
branch
6 times, most recently
from
0739738 to
5604f46
Compare
acsonefho
changed the title
77 tasks
rousseldenis
approved these changes
Sep 30, 2019
simahawk
requested changes
Oct 1, 2019
acsonefho
force-pushed
the
12.0-fw_shopinvader-clear_cart
branch
from
5604f46 to
7e2dede
Compare
Codecov Report
@@ Coverage Diff @@
## 12.0 #444 +/- ##
=========================================
+ Coverage 91.12% 91.22% +0.1%
=========================================
Files 104 104
Lines 2873 2896 +23
=========================================
+ Hits 2618 2642 +24
+ Misses 255 254 -1
Continue to review full report at Codecov.
|
acsonefho
force-pushed
the
12.0-fw_shopinvader-clear_cart
branch
from
7e2dede to
496e09a
Compare
simahawk
approved these changes
Oct 5, 2019
|
This PR has the |
As common tests class are written to create setup data, it is not advised to extend it with test functions as it can annoy further tests.
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
shopinvader-git-bot
pushed a commit
that referenced
this pull request
Oct 7, 2019
|
Congratulations, your PR was merged at bf4808c. Thanks a lot for contributing to shopinvader. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #357 (include cherry-pick of #424 )
Tested in v10.0 (on a real website).
For v12.0, tested with unit test, little bit with swagger but not on a real website.