Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] [FIX] shopinvader: Fix binding not created when a new lang is added #435

Merged

Conversation

lmignon
Copy link
Collaborator

@lmignon lmignon commented Sep 28, 2019

fixes #433

@lmignon lmignon added this to the 12.0 milestone Sep 28, 2019
@codecov-io
Copy link

codecov-io commented Sep 28, 2019

Codecov Report

Merging #435 into 12.0 will decrease coverage by 19.24%.
The diff coverage is 18.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0    #435       +/-   ##
==========================================
- Coverage   56.44%   37.2%   -19.25%     
==========================================
  Files          47      41        -6     
  Lines        1814    1739       -75     
==========================================
- Hits         1024     647      -377     
- Misses        790    1092      +302
Impacted Files Coverage Δ
...ader/wizards/shopinvader_variant_binding_wizard.py 22.8% <15.78%> (+1.53%) ⬆️
...r/wizards/shopinvader_category_unbinding_wizard.py 47.05% <16.66%> (-6.79%) ⬇️
shopinvader/models/shopinvader_backend.py 33.11% <17.24%> (-24.49%) ⬇️
...der/wizards/shopinvader_category_binding_wizard.py 27.65% <23.07%> (+1.34%) ⬆️
...er/wizards/shopinvader_variant_unbinding_wizard.py 44.44% <25%> (-5.56%) ⬇️
shopinvader/services/abstract_sale.py 34.14% <0%> (-58.54%) ⬇️
shopinvader/shopinvader_response.py 43.33% <0%> (-50.01%) ⬇️
base_url/models/abstract_url.py 39.56% <0%> (-41.76%) ⬇️
shopinvader/models/shopinvader_product.py 34.31% <0%> (-34.32%) ⬇️
shopinvader/services/cart.py 26.85% <0%> (-30.29%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7163ecc...26e9397. Read the comment docs.

…d on the backend

Before this change, when a lang was added on a backend, the bindings for the new lang for the already binded product was not created.
fixes shopinvader#435
@lmignon lmignon force-pushed the 12.0-fix-binding-process branch from 7080316 to 26e9397 Compare September 29, 2019 06:19
@lmignon lmignon changed the title [12.0] [WIP] [FIX] shopinvader_assortment: Fix binding not created when a new lang is added [12.0] [FIX] shopinvader: Fix binding not created when a new lang is added Sep 29, 2019
@lmignon
Copy link
Collaborator Author

lmignon commented Sep 29, 2019

/ocabot merge patch

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-435-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Sep 29, 2019
Signed-off-by lmignon
@shopinvader-git-bot shopinvader-git-bot merged commit 26e9397 into shopinvader:12.0 Sep 29, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at f3e59a3. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 12.0-fix-binding-process branch September 29, 2019 07:51
@lmignon lmignon mentioned this pull request Sep 29, 2019
77 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[10.0][12.0] shopinvader: Binding not created when a new lang is added
3 participants