Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][FIX] shopinvader_promotion_rule: avoid to call the auto_apply rule twice after applying a coupon code #426

Merged
merged 1 commit into from
Sep 25, 2019
Merged

[10.0][FIX] shopinvader_promotion_rule: avoid to call the auto_apply rule twice after applying a coupon code #426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions shopinvader_promotion_rule/services/cart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,12 @@ def _update(self, cart, params):
if is_coupon_code_specified:
if coupon_code:
cart.add_coupon(coupon_code)
else:
if cart.coupon_code:
# the promotion has been removed:
# * clear the promotion
cart.clear_promotions()
return res

if cart.coupon_code:
# the promotion has been removed:
# * clear the promotion
cart.clear_promotions()
# apply default promotion
cart.apply_promotions()
return res
Expand Down