Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][IMP]start making compatible new auth-api-key #420

Merged
merged 3 commits into from
Sep 29, 2019

Conversation

lmignon
Copy link
Collaborator

@lmignon lmignon commented Sep 20, 2019

Makes the code working with new auth_api_key implementation.
Proposition with the PR https://github.com/OCA/server-auth/pull/120/files

supersedes #379

@codecov-io
Copy link

codecov-io commented Sep 28, 2019

Codecov Report

Merging #420 into 12.0 will increase coverage by 0.99%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0     #420      +/-   ##
==========================================
+ Coverage   90.12%   91.12%   +0.99%     
==========================================
  Files         104      104              
  Lines        2896     2872      -24     
==========================================
+ Hits         2610     2617       +7     
+ Misses        286      255      -31
Impacted Files Coverage Δ
shopinvader/models/shopinvader_backend.py 86.02% <100%> (+4.21%) ⬆️
...motive/component/shopinvader_site_export_mapper.py 100% <100%> (ø) ⬆️
shopinvader/services/address.py 95.08% <0%> (+1.63%) ⬆️
shopinvader/controllers/main.py 97.14% <0%> (+60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c5bad3...a6853dd. Read the comment docs.

@lmignon lmignon changed the title [12.0][WIP] start making compatible new auth-api-key [12.0][IMP]start making compatible new auth-api-key Sep 28, 2019
@lmignon lmignon added needs review and removed WIP labels Sep 28, 2019
@lmignon lmignon force-pushed the 12.0-aut-api-key branch 2 times, most recently from bdf9c07 to 88f422f Compare September 29, 2019 08:44
@sebastienbeau
Copy link
Contributor

/ocabot mege major

@lmignon lmignon mentioned this pull request Sep 29, 2019
77 tasks
@lmignon
Copy link
Collaborator Author

lmignon commented Sep 29, 2019

/ocabot merge major

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-420-by-lmignon-bump-major, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Sep 29, 2019
Signed-off-by lmignon
@shopinvader-git-bot shopinvader-git-bot merged commit a6853dd into shopinvader:12.0 Sep 29, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 2a2497c. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 12.0-aut-api-key branch September 29, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants