Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] add carrier code into api response #417

Merged
merged 1 commit into from
Apr 17, 2020
Merged

[IMP] add carrier code into api response #417

merged 1 commit into from
Apr 17, 2020

Conversation

sebastienbeau
Copy link
Contributor

No description provided.

@sebastienbeau
Copy link
Contributor Author

regarding port forwarding on 12 I think we miss this commit 5daa01e

@codecov-io
Copy link

codecov-io commented Sep 20, 2019 •
edited
Loading

Codecov Report

Merging #417 into 10.0 will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             10.0     #417      +/-   ##
==========================================
+ Coverage   90.39%   90.42%   +0.03%     
==========================================
  Files         151      151              
  Lines        4048     4051       +3     
==========================================
+ Hits         3659     3663       +4     
+ Misses        389      388       -1
Impacted Files Coverage Δ
...invader_delivery_carrier/services/abstract_sale.py 96.87% <100.00%> (+3.12%) ⬆️
...ader_delivery_carrier/services/delivery_carrier.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81b921...f328ce7. Read the comment docs.

rousseldenis
rousseldenis approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebastienbeau Do you plan to integrate this in tests?

@rousseldenis rousseldenis added this to the 10.0 milestone Nov 28, 2019
@rousseldenis
Copy link
Contributor

@sebastienbeau

@sebastienbeau sebastienbeau self-assigned this Mar 19, 2020
@sebastienbeau
Copy link
Contributor Author

I will add the test

@sebastienbeau sebastienbeau force-pushed the 10.0-add-carrier-code branch from e0143fe to f328ce7 Compare April 4, 2020 08:53
@sebastienbeau
Copy link
Contributor Author

@rousseldenis I have updated my added some test and also refactor the code to avoid duplicated logic between the different service.

rousseldenis
rousseldenis approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM

@sebastienbeau
Copy link
Contributor Author

/ocabot merge minor

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 10.0-ocabot-merge-pr-417-by-sebastienbeau-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Apr 17, 2020
Merge PR #417 into 10.0
219a5fc 
Signed-off-by sebastienbeau
shopinvader-git-bot pushed a commit that referenced this pull request Apr 17, 2020
Merge PR #417 into 10.0
08a275c 
Signed-off-by sebastienbeau
@shopinvader-git-bot
Copy link

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-417-by-sebastienbeau-bump-minor, awaiting test results.

1 similar comment
@shopinvader-git-bot
Copy link

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-417-by-sebastienbeau-bump-minor, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 51da647 into shopinvader:10.0 Apr 17, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 31fe920. Thanks a lot for contributing to shopinvader. ❤️

sebastienbeau added a commit to akretion/odoo-shopinvader that referenced this pull request Aug 25, 2020
@sebastienbeau
[IMP] add carrier code into api response and remove duplicated code s…
66dde06 
…hopinvader#417
@sebastienbeau sebastienbeau mentioned this pull request Aug 25, 2020
Merged
sebastienbeau added a commit to akretion/odoo-shopinvader that referenced this pull request Aug 28, 2020
@sebastienbeau
[IMP] add carrier code into api response and remove duplicated code s…
476b845 
…hopinvader#417
sebastienbeau added a commit that referenced this pull request Aug 29, 2020
@sebastienbeau
[IMP] add carrier code into api response and remove duplicated code #417
bd45ad7
@lmignon lmignon mentioned this pull request Aug 31, 2020
Closed
77 tasks
sebastienbeau added a commit to akretion/odoo-shopinvader that referenced this pull request Sep 1, 2020
@sebastienbeau
[IMP] add carrier code into api response and remove duplicated code s…
05adb5c 
…hopinvader#417
sebastienbeau added a commit to akretion/odoo-shopinvader that referenced this pull request Dec 7, 2020
@sebastienbeau
[IMP] add carrier code into api response and remove duplicated code s…
865b047 
…hopinvader#417
PierrickBrun pushed a commit to akretion/odoo-shopinvader that referenced this pull request Jan 4, 2021
@sebastienbeau
[IMP] add carrier code into api response and remove duplicated code s…
94db9e8 
…hopinvader#417
PierrickBrun pushed a commit to akretion/odoo-shopinvader that referenced this pull request Jan 4, 2021
@sebastienbeau
[IMP] add carrier code into api response and remove duplicated code s…
581d6ac 
…hopinvader#417
PierrickBrun pushed a commit to akretion/odoo-shopinvader that referenced this pull request Jan 25, 2021
@sebastienbeau
[IMP] add carrier code into api response and remove duplicated code s…
41872a5 
…hopinvader#417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees

@sebastienbeau sebastienbeau

Labels
10.0 merged 🎉 needs review
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sebastienbeau @codecov-io @rousseldenis @shopinvader-git-bot