Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][REF] clean shopinvader_quotation #397

Merged
merged 1 commit into from
Oct 7, 2019
Merged

[12.0][REF] clean shopinvader_quotation #397

merged 1 commit into from
Oct 7, 2019

Conversation

sebastienbeau
Copy link
Contributor

@lmignon
use new readme structure
remove useless abstract class (move code in
test_shopinvader_quotation_payment)

@sebastienbeau sebastienbeau force-pushed the 12.0-quotation-clean branch 2 times, most recently from cd31115 to 78b5dfe Compare September 10, 2019 09:21
@sebastienbeau
[REF] clean shopinvader_quotation
fea1a62 
use new readme structure
remove useless abstract class (move code in
test_shopinvader_quotation_payment)
@codecov-io
Copy link

codecov-io commented Sep 10, 2019 •
edited
Loading

Codecov Report

Merging #397 into 12.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             12.0     #397   +/-   ##
=======================================
  Coverage   88.67%   88.67%           
=======================================
  Files          96       96           
  Lines        2595     2595           
=======================================
  Hits         2301     2301           
  Misses        294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1eb27...fea1a62. Read the comment docs.

@lmignon lmignon changed the title [REF] clean shopinvader_quotation [12.0][REF] clean shopinvader_quotation Sep 11, 2019
@lmignon lmignon added this to the 12.0 milestone Sep 11, 2019
@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

simahawk commented Oct 7, 2019

easy merge here guys :)

@lmignon
Copy link
Collaborator

lmignon commented Oct 7, 2019

/ocabot merge patch

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-397-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Oct 7, 2019
Merge PR #397 into 12.0
23df878 
Signed-off-by lmignon
This was referenced Oct 7, 2019
Closed
Merged
@shopinvader-git-bot shopinvader-git-bot merged commit fea1a62 into shopinvader:12.0 Oct 7, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 1d0099e. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sebastienbeau @codecov-io @shopinvader-git-bot @simahawk @lmignon @rousseldenis