Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][ADD] add module shopinvader_delivery_instruction #313

Merged
merged 1 commit into from
Sep 20, 2019
Merged

[10.0][ADD] add module shopinvader_delivery_instruction #313

merged 1 commit into from
Sep 20, 2019

Conversation

acsonefho
Copy link
Contributor

@acsonefho acsonefho commented May 8, 2019 •
edited
Loading

Create a module to let user define a delivery note (for cart).

The user can define a note during cart update. Then (thanks to module sale_stock_picking_note on oca/sale-workflow) this note will be propagated in the picking note.

@acsonefho acsonefho changed the title WIP [10.0][ADD] add module shopinvader_delivery_note [10.0][ADD] add module shopinvader_delivery_note May 8, 2019
@acsonefho acsonefho force-pushed the 10.0-shopinvader_delivery_note branch from 32e0ae4 to fee7a14 Compare May 8, 2019 21:57
@codecov-io
Copy link

codecov-io commented May 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (10.0@80cce1a). Click here to learn what that means.
The diff coverage is 51.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##             10.0     #313   +/-   ##
=======================================
  Coverage        ?   87.95%           
=======================================
  Files           ?      129           
  Lines           ?     3197           
  Branches        ?        0           
=======================================
  Hits            ?     2812           
  Misses          ?      385           
  Partials        ?        0
Impacted Files Coverage Δ
shopinvader_delivery_note/models/sale_order.py 100% <100%> (ø)
shopinvader_delivery_note/services/cart.py 40% <40%> (ø)
shopinvader_delivery_note/models/stock_move.py 44.44% <44.44%> (ø)
...hopinvader_delivery_note/services/abstract_sale.py 57.14% <57.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80cce1a...72c2483. Read the comment docs.

@acsonefho acsonefho force-pushed the 10.0-shopinvader_delivery_note branch from fee7a14 to 68ab9d6 Compare May 10, 2019 12:15
@lmignon lmignon added this to the 10.0 milestone Jun 12, 2019
@lmignon
Copy link
Collaborator

lmignon commented Aug 29, 2019

@acsonefho This PR depends on others PRS. It seems that these others PRS are waiting for your input. My main concern is about OCA/stock-logistics-workflow#524 (comment)
It seems that you've developed new addons for functionality already provided by an existing one. Therefore this enhancement should be based on the existing one...

@acsonefho acsonefho force-pushed the 10.0-shopinvader_delivery_note branch from 68ab9d6 to ce29703 Compare September 17, 2019 12:41
@acsonefho acsonefho mentioned this pull request Sep 19, 2019
Merged
1 task
@acsonefho acsonefho force-pushed the 10.0-shopinvader_delivery_note branch from ce29703 to 54ff4d1 Compare September 19, 2019 11:56
lmignon
lmignon requested changes Sep 19, 2019
View reviewed changes
@acsonefho acsonefho force-pushed the 10.0-shopinvader_delivery_note branch from 54ff4d1 to f2f29cb Compare September 19, 2019 14:28
@acsonefho acsonefho force-pushed the 10.0-shopinvader_delivery_note branch from f2f29cb to 72c2483 Compare September 19, 2019 14:29
@lmignon lmignon added 10.0 and removed invalid labels Sep 19, 2019
@lmignon lmignon changed the title [10.0][ADD] add module shopinvader_delivery_note [10.0][ADD] add module shopinvader_delivery_instruction Sep 19, 2019
@lmignon
Copy link
Collaborator

lmignon commented Sep 19, 2019

Once merged we must create an issue to forward port this PR into 12.0 Nevertheless, sale_stock_picking_note is not yet migrated into 12.0

rousseldenis
rousseldenis approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code review

@lmignon
Copy link
Collaborator

lmignon commented Sep 20, 2019

/ocabot merge patch

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 10.0-ocabot-merge-pr-313-by-lmignon-bump-patch, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Sep 20, 2019
Merge PR #313 into 10.0
4c2dd11 
Signed-off-by lmignon
@lmignon lmignon mentioned this pull request Sep 20, 2019
Closed
77 tasks
@shopinvader-git-bot shopinvader-git-bot merged commit 72c2483 into shopinvader:10.0 Sep 20, 2019
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at d29f921. Thanks a lot for contributing to shopinvader. ❤️

@lmignon lmignon deleted the 10.0-shopinvader_delivery_note branch September 20, 2019 11:25
@acsonefho acsonefho mentioned this pull request Sep 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@Cedric-Pigeon Cedric-Pigeon Cedric-Pigeon approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
10.0 approved merged 🎉 ready to merge
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@acsonefho @codecov-io @lmignon @shopinvader-git-bot @Cedric-Pigeon @rousseldenis