[16.0] [IMP] shopinvader_api_cart: don't use self.env.norecompute
#1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This context manager has been deprecated since many versions now, and it's not doing absolutely anything. It was originally used to prevent computed fields to be recomputed when their dependencies are updated, but that's not the case anymore since the apparition of `flush`, where the recomputation is delayed. See: https://github.com/odoo/odoo/blob/be4c1502/odoo/api.py#L823-L826 Also: odoo/odoo@9920f20e
santostelmo
approved these changes
Feb 9, 2024
simahawk
approved these changes
Feb 9, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at f833d61. Thanks a lot for contributing to shopinvader. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This context manager has been deprecated since many versions now, and it's not doing absolutely anything.
It was originally used to prevent computed fields to be recomputed when their dependencies are updated, but that's not the case anymore since the apparition of
flush, where the recomputation is delayed.See: https://github.com/odoo/odoo/blob/be4c1502/odoo/api.py#L823-L826
Also: odoo/odoo@9920f20e