Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [FIX] shopinvader_api_cart: fix the empty cart creation upon update #1499

Conversation

ivantodorovich
Copy link
Contributor

Steps to reproduce:

  • Perform an update without any existing cart

Exception:

TypeError: SaleOrder._create_empty_cart() missing 1 required positional
argument: 'partner_id'

@ivantodorovich ivantodorovich force-pushed the 16.0-fix-cart-update-create-if-missing branch from 3b4e3f5 to 7721d8e Compare February 8, 2024 17:41
Steps to reproduce:

- Perform an update without any existing cart

Exception:

```
TypeError: SaleOrder._create_empty_cart() missing 1 required positional
argument: 'partner_id'
```
@ivantodorovich ivantodorovich force-pushed the 16.0-fix-cart-update-create-if-missing branch from 7721d8e to 3062179 Compare February 8, 2024 17:41
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link
Contributor

@marielejeune marielejeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmignon
Copy link
Collaborator

lmignon commented Feb 12, 2024

/ocabot merge patch

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1499-by-lmignon-bump-patch, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 95261c4 into shopinvader:16.0 Feb 12, 2024
3 checks passed
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 0e68206. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants