Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate react-router to v4.x #26

Closed
shogowada opened this issue Apr 14, 2017 · 0 comments
Closed

Migrate react-router to v4.x #26

shogowada opened this issue Apr 14, 2017 · 0 comments

Comments

@shogowada
Copy link
Owner

See https://reacttraining.com/react-router/web/guides/quick-start for details

shogowada added a commit that referenced this issue Apr 15, 2017
shogowada added a commit that referenced this issue Apr 15, 2017
* Correct props

- Create react element via <(ReactClassSpec)(attribute: Any*)(contents: Any*) method
- Specify props via ^.wrapped attribute
- Use props.children to access children
- Use props.router, props.location, etc to access router props

* Fix travis CI

* Use Chrome instead

* Fix travis CI

* Fix travis CI

* Remove children method

It is replaced by props.children

* Create react-router-dom facade

* Drop 2.11 support

It was having issue resolving class for WebBrowser for no obvious reason.

* Update README.md

* Update documentations

Close #26

* Drop Scala 2.11 from travis

* Update README.md

* Remove comments

* Update documents

* Update README.md

* Update Main.scala

* Loosen selenium version

Travis is having issue finding 3.3.1

* Try installing newer chromdriver

* Revert manually downloding chromedriver

* Install google-chrome-stable

* Revert "Install google-chrome-stable"

This reverts commit d1f45c3.

* Install Chrome

* Use chromedriver 2.28

According to https://bugs.chromium.org/p/chromedriver/issues/detail?id=1467, it has the fix for alert hanging.

* Ignore unexpected alert

* Use singleton FirefoxDriver

* Install geckodriver

* Fix gecko download path

* Do not use trusty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant