Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/not found tracking #1017

Merged
merged 30 commits into from
Feb 11, 2021

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Feb 11, 2021

Closes #675

acelaya and others added 30 commits February 9, 2021 23:09
@codecov-io
Copy link

Codecov Report

Merging #1017 (cc68cb9) into develop (f4623ed) will increase coverage by 0.03%.
The diff coverage is 99.03%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1017      +/-   ##
=============================================
+ Coverage      97.58%   97.62%   +0.03%     
- Complexity       900      953      +53     
=============================================
  Files            151      160       +9     
  Lines           2979     3113     +134     
=============================================
+ Hits            2907     3039     +132     
- Misses            72       74       +2     
Impacted Files Coverage Δ Complexity Δ
module/Core/src/Action/AbstractTrackingAction.php 100.00% <ø> (ø) 10.00 <0.00> (ø)
module/Core/src/Action/RedirectAction.php 100.00% <ø> (ø) 3.00 <0.00> (ø)
...dule/Core/src/EventDispatcher/Event/UrlVisited.php 100.00% <ø> (ø) 2.00 <0.00> (?)
...odule/Core/src/ErrorHandler/Model/NotFoundType.php 88.88% <88.88%> (ø) 8.00 <8.00> (?)
...dule/CLI/src/Command/ShortUrl/GetVisitsCommand.php 87.87% <100.00%> (+0.37%) 8.00 <1.00> (ø)
module/Core/src/Entity/Visit.php 100.00% <100.00%> (ø) 22.00 <9.00> (+7.00)
.../Core/src/ErrorHandler/NotFoundRedirectHandler.php 100.00% <100.00%> (ø) 8.00 <0.00> (-3.00)
.../Core/src/ErrorHandler/NotFoundTemplateHandler.php 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
...ore/src/ErrorHandler/NotFoundTrackerMiddleware.php 100.00% <100.00%> (ø) 5.00 <5.00> (?)
...rc/ErrorHandler/NotFoundTypeResolverMiddleware.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4623ed...cc68cb9. Read the comment docs.

@acelaya acelaya merged commit db6c83e into shlinkio:develop Feb 11, 2021
@acelaya acelaya deleted the feature/not-found-tracking branch February 11, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track visits to 'base_url', 'invalid_short_url' and 'regular_404' (orphan visits)
2 participants