Remove deprecated config options

CHANGELOG.md

@@ -10,12 +10,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com), and this
 
 ### Changed
 * Update dependencies
+* Default value for QR codes enabled for disabled short URLs is now true.
 
 ### Deprecated
 * *Nothing*
 
 ### Removed
-* *Nothing*
+* Remove config options related with webhooks.
+* Remove config option to decode redis credentials.
 
 ### Fixed
 * *Nothing*

config/config.php

@@ -63,8 +63,6 @@
                     => Config\Option\UrlShortener\EnableMultiSegmentSlugsConfigOption::class,
                 'URL shortener > Trailing slashes' => Config\Option\UrlShortener\EnableTrailingSlashConfigOption::class,
                 'URL shortener > Mode' => Config\Option\UrlShortener\ShortUrlModeConfigOption::class,
-                'Webhooks > List' => Config\Option\Visit\VisitsWebhooksConfigOption::class,
-                'Webhooks > Orphan visits' => Config\Option\Visit\OrphanVisitsWebhooksConfigOption::class,
                 'GeoLite2 license key' => Config\Option\UrlShortener\GeoLiteLicenseKeyConfigOption::class,
                 'Redirects > Status code (301/302)' => Config\Option\UrlShortener\RedirectStatusCodeConfigOption::class,
                 'Redirects > Caching life time' => Config\Option\UrlShortener\RedirectCacheLifeTimeConfigOption::class,
@@ -104,7 +102,6 @@
             ],
             'INTEGRATIONS' => [
                 'Redis > servers' => Config\Option\Redis\RedisServersConfigOption::class,
-                'Redis > decode credentials' => Config\Option\Redis\RedisDecodeCredentialsConfigOption::class,
                 'Redis > sentinels service' => Config\Option\Redis\RedisSentinelServiceConfigOption::class,
                 'Redis > Pub/sub enabled' => Config\Option\Redis\RedisPubSubConfigOption::class,
                 Config\Option\Mercure\EnableMercureConfigOption::class,
@@ -149,11 +146,8 @@
             Config\Option\UrlShortener\EnableTrailingSlashConfigOption::class => InvokableFactory::class,
             Config\Option\UrlShortener\ShortUrlModeConfigOption::class => InvokableFactory::class,
             Config\Option\Redis\RedisServersConfigOption::class => InvokableFactory::class,
-            Config\Option\Redis\RedisDecodeCredentialsConfigOption::class => InvokableFactory::class,
             Config\Option\Redis\RedisSentinelServiceConfigOption::class => InvokableFactory::class,
             Config\Option\Redis\RedisPubSubConfigOption::class => InvokableFactory::class,
-            Config\Option\Visit\VisitsWebhooksConfigOption::class => InvokableFactory::class,
-            Config\Option\Visit\OrphanVisitsWebhooksConfigOption::class => InvokableFactory::class,
             Config\Option\Worker\TaskWorkerNumConfigOption::class => InvokableFactory::class,
             Config\Option\Worker\WebWorkerNumConfigOption::class => InvokableFactory::class,
             Config\Option\UrlShortener\ShortCodeLengthOption::class => InvokableFactory::class,

src/Config/Option/QrCode/EnabledForDisabledShortUrlsConfigOption.php

@@ -20,8 +20,6 @@ public function ask(StyleInterface $io, array $currentOptions): bool
             'Should Shlink be able to generate QR codes for short URLs which are not enabled? (Short URLs are not '
             . 'enabled if they have a "valid since" in the future, a "valid until" in the past, or reached the maximum '
             . 'amount of allowed visits)',
-            // Deprecated. Shlink 4.0.0 should change default value to `true`
-            false,
         );
     }
 }

src/Config/Option/UrlShortener/ShortUrlModeConfigOption.php

@@ -5,12 +5,11 @@
 namespace Shlinkio\Shlink\Installer\Config\Option\UrlShortener;
 
 use Shlinkio\Shlink\Installer\Config\Option\BaseConfigOption;
-use Shlinkio\Shlink\Installer\Config\Option\ConfigOptionMigratorInterface;
 use Symfony\Component\Console\Style\StyleInterface;
 
 use const PHP_EOL;
 
-class ShortUrlModeConfigOption extends BaseConfigOption implements ConfigOptionMigratorInterface
+class ShortUrlModeConfigOption extends BaseConfigOption
 {
     private const MODES = [
         'strict' => 'Short codes and custom slugs will be matched in a case-sensitive way ("foo" !== "FOO"). '
@@ -37,9 +36,4 @@ public function ask(StyleInterface $io, array $currentOptions): string
             'strict',
         );
     }
-
-    public function tryToMigrateValue(mixed $currentValue): mixed
-    {
-        return $currentValue === 'loosely' ? 'loose' : $currentValue;
-    }
 }

test/Config/Option/QrCode/EnabledForDisabledShortUrlsConfigOptionTest.php

@@ -32,7 +32,6 @@ public function expectedQuestionIsAsked(): void
             'Should Shlink be able to generate QR codes for short URLs which are not enabled? (Short URLs are not '
             . 'enabled if they have a "valid since" in the future, a "valid until" in the past, or reached the maximum '
             . 'amount of allowed visits)',
-            false,
         )->willReturn(true);
 
         $answer = $this->configOption->ask($io, []);

test/Config/Option/UrlShortener/ShortUrlModeConfigOptionTest.php

@@ -51,17 +51,4 @@ public static function provideChoices(): iterable
         yield 'strict' => ['strict'];
         yield 'loose' => ['loose'];
     }
-
-    #[Test, DataProvider('provideMigrationValues')]
-    public function deprecatedValueIsProperlyMigrated(string $existingValue, string $expectedResult): void
-    {
-        self::assertEquals($expectedResult, $this->configOption->tryToMigrateValue($existingValue));
-    }
-
-    public static function provideMigrationValues(): iterable
-    {
-        yield 'strict' => ['strict', 'strict'];
-        yield 'loose' => ['loose', 'loose'];
-        yield 'loosely' => ['loosely', 'loose'];
-    }
 }