Merge pull request #53 from acelaya-forks/feature/remove-geolite-down…

…load Feature/remove geolite download
shlinkio · Jan 5, 2020 · 3a936ba · 3a936ba
2 parents e5463ad + 6b11ede
commit 3a936ba
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 14 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -23,6 +23,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com), and this
 #### Removed
 
 * [#43](https://github.com/shlinkio/shlink-installer/issues/43) Dropped support for PHP 7.2 and 7.3
+* [#52](https://github.com/shlinkio/shlink-installer/issues/52) GeoLite2 db is no longer downloaded during installation.
 
 #### Fixed
 

diff --git a/README.md b/README.md
@@ -100,9 +100,6 @@ return [
             'orm_proxies' => [
                 'command' => '-v', // Just print PHP version
             ],
-            'geolite_download' => [
-                'command' => '-v', // Just print PHP version
-            ],
         ],
     ],
 

diff --git a/config/config.local.php.dist b/config/config.local.php.dist
@@ -15,9 +15,6 @@ return [
             'orm_proxies' => [
                 'command' => '-v', // Just print PHP version
             ],
-            'geolite_download' => [
-                'command' => '-v', // Just print PHP version
-            ],
         ],
     ],
 

diff --git a/config/config.php b/config/config.php
@@ -108,11 +108,6 @@
                 'initMessage' => 'Generating proxies...',
                 'errorMessage' => 'Error generating proxies.',
             ],
-            'geolite_download' => [
-                'command' => 'bin/cli visit:update-db',
-                'initMessage' => 'Downloading GeoLite2 db...',
-                'errorMessage' => 'Error downloading GeoLite2 db.',
-            ],
         ],
     ],
 

diff --git a/src/Command/InstallCommand.php b/src/Command/InstallCommand.php
@@ -31,7 +31,6 @@ class InstallCommand extends Command
         'db_create_schema',
         'db_migrate',
         'orm_proxies',
-        'geolite_download',
     ];
     private const SQLITE_DB_PATH = 'data/database.sqlite';
 

diff --git a/test/Command/InstallCommandTest.php b/test/Command/InstallCommandTest.php
@@ -190,8 +190,8 @@ public function commandRunnerIsInvokedTheProperAmountOfTimes(bool $isUpdate, int
 
     public function provideAmounts(): iterable
     {
-        yield [false, 4];
-        yield [true, 3];
+        yield [false, 3];
+        yield [true, 2];
     }
 
     private function setIsUpdate(bool $isUpdate = true): void